Conversation
* Pin foundry to v1.5.0 instead of nightly (0xsequence#947) (#134) * Bump next from 15.5.7 to 15.5.9 (0xsequence#944) Bumps [next](https://github.com/vercel/next.js) from 15.5.7 to 15.5.9. - [Release notes](https://github.com/vercel/next.js/releases) - [Changelog](https://github.com/vercel/next.js/blob/canary/release.js) - [Commits](vercel/next.js@v15.5.7...v15.5.9) --- updated-dependencies: - dependency-name: next dependency-version: 15.5.9 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Pin foundry to v1.5.0 instead of nightly (0xsequence#947) * Include repo and extras in syncpack config to ensure deps are synced (0xsequence#945) * Include repo and extras in syncpack config to ensure deps are synced across all * Updating support deps * Updating deps * Updating pnpm lock * Fixing type errors within wdk tests * Short circuit 404s (0xsequence#949) * skip witness on signers that don't support it * add passkey to test * 3.0.0-beta.6 --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Taylan Pince <taylanpince@gmail.com> Co-authored-by: Corban Riley <corbanbrook@gmail.com> Co-authored-by: Agusx1211 <agusgit@pm.me> * Update packages/wallet/wdk/test/wallets.test.ts Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com> * Update packages/wallet/wdk/test/wallets.test.ts Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com> --------- Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Taylan Pince <taylanpince@gmail.com> Co-authored-by: Corban Riley <corbanbrook@gmail.com> Co-authored-by: Agusx1211 <agusgit@pm.me> Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
* Fix apple auth scope * Fix Apple auth scope test
|
|
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
Reviewer's GuideIntroduces Apple authentication-specific behavior across the wallet WDK and related services, bumps multiple packages from 3.0.0-beta.6 to 3.0.0-beta.8 with corresponding changelog and changeset entries, and slightly extends the dapp-client public API exports. Sequence diagram for AuthCodeHandler OAuth URL construction for Apple vs non-ApplesequenceDiagram
actor User
participant DappClient
participant AuthCodeHandler
participant OAuthProvider
User->>DappClient: initiateSignup(signupKind)
DappClient->>AuthCodeHandler: buildAuthUrl(signupKind, state)
AuthCodeHandler->>AuthCodeHandler: createSearchParams(audience, redirectUri, responseType)
alt signupKind_is_apple
AuthCodeHandler->>AuthCodeHandler: omit_scope_parameter
else signupKind_is_not_apple
AuthCodeHandler->>AuthCodeHandler: add_scope_openid_profile_email
end
AuthCodeHandler->>DappClient: return_oauthUrl_with_query
DappClient->>User: redirect_to_oauthUrl
User->>OAuthProvider: authenticate
OAuthProvider-->>DappClient: redirect_back_with_auth_code
Flow diagram for conditional scope parameter in AuthCodeHandlerflowchart TD
A[Start buildAuthUrl] --> B[Set base params client_id, redirect_uri, response_type, state]
B --> C{Is signupKind apple}
C -->|Yes| D[Do not include scope parameter]
C -->|No| E[Add scope openid profile email]
D --> F[Build OAuth URL with current params]
E --> F[Build OAuth URL with current params]
F --> G[Return OAuth URL]
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Summary of ChangesHello @Dargon789, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request primarily focuses on enhancing the Apple authentication process within the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- In
AuthCodeHandler.createAuthorizeUrl, consider extracting the Apple-specific query parameter logic into a small helper (e.g.,buildOAuthSearchParams(signupKind, ...)) so that provider-specific differences are isolated and easier to extend if additional providers require custom handling. - You added two changesets (
new-turkeys-doubleandnice-tips-slide) that both describe Apple auth fixes for the same set of packages; double-check whether you really need both or if one is now redundant and can be removed to avoid duplicate patch releases.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- In `AuthCodeHandler.createAuthorizeUrl`, consider extracting the Apple-specific query parameter logic into a small helper (e.g., `buildOAuthSearchParams(signupKind, ...)`) so that provider-specific differences are isolated and easier to extend if additional providers require custom handling.
- You added two changesets (`new-turkeys-double` and `nice-tips-slide`) that both describe Apple auth fixes for the same set of packages; double-check whether you really need both or if one is now redundant and can be removed to avoid duplicate patch releases.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
There was a problem hiding this comment.
Code Review
This pull request releases version 3.0.0-beta.8 for a number of packages, primarily including a fix for Apple authentication to avoid sending the scope parameter in the authorization URL. The change is well-implemented and covered by a new test case. Additionally, TransportMessage and MessageType types are now exported from the dapp-client package. My main feedback is regarding the use of two separate and confusingly similar changesets for what appears to be a single logical change, which could lead to a confusing changelog. Consolidating them would improve clarity.
|
34c8d15 reley login slowdown help config ux ui connect wagmi viem point Dargon789/wagmi@46c8952 @tolgahan-arikan @taylanpince @corbanbrook thank you. |
* [AUTOMATED] Update: proto/clients/indexer*.gen.ts * [AUTOMATED] Update: proto/clients/indexer*.gen.ts * [AUTOMATED] Update: proto/clients/indexer*.gen.ts * [AUTOMATED] Update: proto/clients/indexer*.gen.ts * [AUTOMATED] Update: proto/clients/indexer*.gen.ts * [AUTOMATED] Update: proto/clients/indexer*.gen.ts * [AUTOMATED] Update: proto/clients/indexer*.gen.ts * [AUTOMATED] Update: proto/clients/indexer*.gen.ts --------- Co-authored-by: marino39 <722509+marino39@users.noreply.github.com> Co-authored-by: pkieltyka <18831+pkieltyka@users.noreply.github.com> Co-authored-by: xiam <385670+xiam@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Summary by Sourcery
Release beta.8 of the wallet, services, and utils packages with updated Apple authentication handling and synced versions across the monorepo.
Bug Fixes:
Enhancements:
Build: