Skip to content

Wagmi project#199

Merged
Dargon789 merged 10 commits intomasterfrom
wagmi-project
Jan 19, 2026
Merged

Wagmi project#199
Dargon789 merged 10 commits intomasterfrom
wagmi-project

Conversation

@Dargon789
Copy link
Owner

@Dargon789 Dargon789 commented Jan 9, 2026

Summary by Sourcery

Release beta.8 of the wallet, services, and utils packages with updated Apple authentication handling and synced versions across the monorepo.

Bug Fixes:

  • Adjust Apple OAuth authorization URL construction to avoid passing scope for Apple signups and add coverage to ensure no scope parameter is sent.
  • Fix Apple authentication flows across wallet, services, and ABI-related packages.

Enhancements:

  • Expose additional dapp-client transport types, including TransportMessage and MessageType, from the public index.

Build:

  • Bump multiple package versions to 3.0.0-beta.8 and add corresponding changesets for coordinated patch releases.

Dargon789 and others added 8 commits December 29, 2025 17:13
* Pin foundry to v1.5.0 instead of nightly (0xsequence#947) (#134)

* Bump next from 15.5.7 to 15.5.9 (0xsequence#944)

Bumps [next](https://github.com/vercel/next.js) from 15.5.7 to 15.5.9.
- [Release notes](https://github.com/vercel/next.js/releases)
- [Changelog](https://github.com/vercel/next.js/blob/canary/release.js)
- [Commits](vercel/next.js@v15.5.7...v15.5.9)

---
updated-dependencies:
- dependency-name: next
  dependency-version: 15.5.9
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Pin foundry to v1.5.0 instead of nightly (0xsequence#947)

* Include repo and extras in syncpack config to ensure deps are synced (0xsequence#945)

* Include repo and extras in syncpack config to ensure deps are synced across all

* Updating support deps

* Updating deps

* Updating pnpm lock

* Fixing type errors within wdk tests

* Short circuit 404s (0xsequence#949)

* skip witness on signers that don't support it

* add passkey to test

* 3.0.0-beta.6

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Taylan Pince <taylanpince@gmail.com>
Co-authored-by: Corban Riley <corbanbrook@gmail.com>
Co-authored-by: Agusx1211 <agusgit@pm.me>

* Update packages/wallet/wdk/test/wallets.test.ts

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com>

* Update packages/wallet/wdk/test/wallets.test.ts

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com>

---------

Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Taylan Pince <taylanpince@gmail.com>
Co-authored-by: Corban Riley <corbanbrook@gmail.com>
Co-authored-by: Agusx1211 <agusgit@pm.me>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
* Fix apple auth scope

* Fix Apple auth scope test
@bolt-new-by-stackblitz
Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@codesandbox
Copy link

codesandbox bot commented Jan 9, 2026

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

@sourcery-ai
Copy link

sourcery-ai bot commented Jan 9, 2026

Reviewer's Guide

Introduces Apple authentication-specific behavior across the wallet WDK and related services, bumps multiple packages from 3.0.0-beta.6 to 3.0.0-beta.8 with corresponding changelog and changeset entries, and slightly extends the dapp-client public API exports.

Sequence diagram for AuthCodeHandler OAuth URL construction for Apple vs non-Apple

sequenceDiagram
  actor User
  participant DappClient
  participant AuthCodeHandler
  participant OAuthProvider

  User->>DappClient: initiateSignup(signupKind)
  DappClient->>AuthCodeHandler: buildAuthUrl(signupKind, state)
  AuthCodeHandler->>AuthCodeHandler: createSearchParams(audience, redirectUri, responseType)
  alt signupKind_is_apple
    AuthCodeHandler->>AuthCodeHandler: omit_scope_parameter
  else signupKind_is_not_apple
    AuthCodeHandler->>AuthCodeHandler: add_scope_openid_profile_email
  end
  AuthCodeHandler->>DappClient: return_oauthUrl_with_query
  DappClient->>User: redirect_to_oauthUrl
  User->>OAuthProvider: authenticate
  OAuthProvider-->>DappClient: redirect_back_with_auth_code
Loading

Flow diagram for conditional scope parameter in AuthCodeHandler

flowchart TD
  A[Start buildAuthUrl] --> B[Set base params client_id, redirect_uri, response_type, state]
  B --> C{Is signupKind apple}
  C -->|Yes| D[Do not include scope parameter]
  C -->|No| E[Add scope openid profile email]
  D --> F[Build OAuth URL with current params]
  E --> F[Build OAuth URL with current params]
  F --> G[Return OAuth URL]
Loading

File-Level Changes

Change Details Files
Adjust OAuth authorization URL construction to omit scope for Apple signups and update associated tests.
  • Modify AuthCodeHandler to conditionally exclude the scope parameter when signupKind is 'apple' while preserving it for other providers.
  • Update authcode handler tests to assert that Apple authorization URLs do not include a scope query parameter.
packages/wallet/wdk/src/sequence/handlers/authcode.ts
packages/wallet/wdk/test/authcode.test.ts
Expand the dapp-client public API surface to include additional transport-related types and enums.
  • Re-export TransportMessage type from dapp-client types index through the main entrypoint.
  • Expose MessageType enum alongside RequestActionType and TransportMode from the main dapp-client index.
packages/wallet/dapp-client/src/index.ts
Version bump multiple packages to 3.0.0-beta.8 and document Apple auth fixes and dependency updates in changelogs and changesets.
  • Update package.json versions for services, wallet, and utils packages from 3.0.0-beta.6 to 3.0.0-beta.8.
  • Add 3.0.0-beta.7 and 3.0.0-beta.8 sections to multiple package changelogs describing Apple auth fixes and updated internal dependencies.
  • Add two new changeset files describing Apple auth fix/fixes across affected packages.
  • Adjust pre-release changeset metadata as part of the versioning flow.
packages/wallet/wdk/CHANGELOG.md
packages/wallet/dapp-client/CHANGELOG.md
packages/wallet/core/CHANGELOG.md
packages/services/relayer/CHANGELOG.md
packages/services/api/CHANGELOG.md
packages/services/builder/CHANGELOG.md
packages/services/guard/CHANGELOG.md
packages/services/identity-instrument/CHANGELOG.md
packages/services/indexer/CHANGELOG.md
packages/services/marketplace/CHANGELOG.md
packages/services/metadata/CHANGELOG.md
packages/services/userdata/CHANGELOG.md
packages/utils/abi/CHANGELOG.md
packages/wallet/primitives/CHANGELOG.md
packages/services/api/package.json
packages/services/builder/package.json
packages/services/guard/package.json
packages/services/identity-instrument/package.json
packages/services/indexer/package.json
packages/services/marketplace/package.json
packages/services/metadata/package.json
packages/services/relayer/package.json
packages/services/userdata/package.json
packages/utils/abi/package.json
packages/wallet/core/package.json
packages/wallet/dapp-client/package.json
packages/wallet/primitives/package.json
packages/wallet/wdk/package.json
.changeset/new-turkeys-double.md
.changeset/nice-tips-slide.md
.changeset/pre.json

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@snyk-io
Copy link

snyk-io bot commented Jan 9, 2026

Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@gemini-code-assist
Copy link

Summary of Changes

Hello @Dargon789, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request primarily focuses on enhancing the Apple authentication process within the @0xsequence ecosystem by implementing a targeted fix for the scope parameter in authorization URL generation. This change ensures compliance with Apple's authentication standards, improving the reliability of sign-in flows. Concurrently, it includes a broad update of various @0xsequence packages to reflect these critical fixes and introduces new type exports for better developer experience in the dapp client.

Highlights

  • Apple Authentication Fixes: The authentication flow for Apple sign-ups has been updated to conditionally omit the scope parameter when building the authorization URL, addressing specific requirements for Apple authentication. This ensures proper integration and functionality for users signing in with Apple.
  • Package Version Bumps: Numerous @0xsequence packages, including @0xsequence/api, @0xsequence/builder, @0xsequence/guard, @0xsequence/identity-instrument, @0xsequence/indexer, @0xsequence/marketplace, @0xsequence/metadata, @0xsequence/relayer, @0xsequence/userdata, @0xsequence/abi, @0xsequence/wallet-core, @0xsequence/dapp-client, @0xsequence/wallet-primitives, and @0xsequence/wallet-wdk, have been updated to version 3.0.0-beta.8 to incorporate these authentication fixes and related dependency updates.
  • New Types Exported in Dapp Client: The @0xsequence/dapp-client package now exports TransportMessage and MessageType from its types index, making these essential types available for external use.
  • Improved Test Coverage: A new test assertion has been added to packages/wallet/wdk/test/authcode.test.ts to explicitly verify that the scope parameter is correctly omitted from the Apple authentication URL, ensuring the fix behaves as expected.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Repository owner deleted a comment from vercel bot Jan 9, 2026
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • In AuthCodeHandler.createAuthorizeUrl, consider extracting the Apple-specific query parameter logic into a small helper (e.g., buildOAuthSearchParams(signupKind, ...)) so that provider-specific differences are isolated and easier to extend if additional providers require custom handling.
  • You added two changesets (new-turkeys-double and nice-tips-slide) that both describe Apple auth fixes for the same set of packages; double-check whether you really need both or if one is now redundant and can be removed to avoid duplicate patch releases.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- In `AuthCodeHandler.createAuthorizeUrl`, consider extracting the Apple-specific query parameter logic into a small helper (e.g., `buildOAuthSearchParams(signupKind, ...)`) so that provider-specific differences are isolated and easier to extend if additional providers require custom handling.
- You added two changesets (`new-turkeys-double` and `nice-tips-slide`) that both describe Apple auth fixes for the same set of packages; double-check whether you really need both or if one is now redundant and can be removed to avoid duplicate patch releases.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request releases version 3.0.0-beta.8 for a number of packages, primarily including a fix for Apple authentication to avoid sending the scope parameter in the authorization URL. The change is well-implemented and covered by a new test case. Additionally, TransportMessage and MessageType types are now exported from the dapp-client package. My main feedback is regarding the use of two separate and confusingly similar changesets for what appears to be a single logical change, which could lead to a confusing changelog. Consolidating them would improve clarity.

@Dargon789 Dargon789 enabled auto-merge January 9, 2026 12:38
@Dargon789 Dargon789 self-assigned this Jan 9, 2026
@Dargon789 Dargon789 added documentation Improvements or additions to documentation duplicate This issue or pull request already exists enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers invalid This doesn't seem right question Further information is requested dependencies Pull requests that update a dependency file javascript Pull requests that update javascript code labels Jan 9, 2026
@Dargon789
Copy link
Owner Author

34c8d15 reley login slowdown help config ux ui connect wagmi viem point Dargon789/wagmi@46c8952 @tolgahan-arikan @taylanpince @corbanbrook thank you.

* [AUTOMATED] Update: proto/clients/indexer*.gen.ts

* [AUTOMATED] Update: proto/clients/indexer*.gen.ts

* [AUTOMATED] Update: proto/clients/indexer*.gen.ts

* [AUTOMATED] Update: proto/clients/indexer*.gen.ts

* [AUTOMATED] Update: proto/clients/indexer*.gen.ts

* [AUTOMATED] Update: proto/clients/indexer*.gen.ts

* [AUTOMATED] Update: proto/clients/indexer*.gen.ts

* [AUTOMATED] Update: proto/clients/indexer*.gen.ts

---------

Co-authored-by: marino39 <722509+marino39@users.noreply.github.com>
Co-authored-by: pkieltyka <18831+pkieltyka@users.noreply.github.com>
Co-authored-by: xiam <385670+xiam@users.noreply.github.com>
@vercel
Copy link

vercel bot commented Jan 17, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
sequence-js-docs Ready Ready Preview, Comment Jan 19, 2026 7:18am
sequence-js-web Ready Ready Preview, Comment Jan 19, 2026 7:18am

Repository owner deleted a comment from vercel bot Jan 19, 2026
@Dargon789 Dargon789 disabled auto-merge January 19, 2026 07:21
@Dargon789 Dargon789 merged commit ec3d1c6 into master Jan 19, 2026
10 of 14 checks passed
@Dargon789 Dargon789 deleted the wagmi-project branch January 19, 2026 07:21
@github-project-automation github-project-automation bot moved this from Backlog to Done in Hardhat Jan 19, 2026
@github-project-automation github-project-automation bot moved this from Todo to Done in web3-Defi-Gamefi Jan 19, 2026
@Dargon789 Dargon789 restored the wagmi-project branch January 19, 2026 07:35
@Dargon789 Dargon789 linked an issue Jan 19, 2026 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file documentation Improvements or additions to documentation duplicate This issue or pull request already exists enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed invalid This doesn't seem right javascript Pull requests that update javascript code question Further information is requested

Projects

Archived in project
Status: Done

4 participants