forked from 0xsequence/sequence.js
-
Notifications
You must be signed in to change notification settings - Fork 1
Closed
Closed
Copy link
Labels
dependenciesPull requests that update a dependency filePull requests that update a dependency filedocumentationImprovements or additions to documentationImprovements or additions to documentationduplicateThis issue or pull request already existsThis issue or pull request already existsenhancementNew feature or requestNew feature or requestgood first issueGood for newcomersGood for newcomershelp wantedExtra attention is neededExtra attention is neededinvalidThis doesn't seem rightThis doesn't seem rightjavascriptPull requests that update javascript codePull requests that update javascript codequestionFurther information is requestedFurther information is requested
Description
Reviewer's Guide
Introduces Apple authentication-specific behavior across the wallet WDK and related services, bumps multiple packages from 3.0.0-beta.6 to 3.0.0-beta.8 with corresponding changelog and changeset entries, and slightly extends the dapp-client public API exports.
Sequence diagram for AuthCodeHandler OAuth URL construction for Apple vs non-Apple
sequenceDiagram
actor User
participant DappClient
participant AuthCodeHandler
participant OAuthProvider
User->>DappClient: initiateSignup(signupKind)
DappClient->>AuthCodeHandler: buildAuthUrl(signupKind, state)
AuthCodeHandler->>AuthCodeHandler: createSearchParams(audience, redirectUri, responseType)
alt signupKind_is_apple
AuthCodeHandler->>AuthCodeHandler: omit_scope_parameter
else signupKind_is_not_apple
AuthCodeHandler->>AuthCodeHandler: add_scope_openid_profile_email
end
AuthCodeHandler->>DappClient: return_oauthUrl_with_query
DappClient->>User: redirect_to_oauthUrl
User->>OAuthProvider: authenticate
OAuthProvider-->>DappClient: redirect_back_with_auth_code
Flow diagram for conditional scope parameter in AuthCodeHandler
flowchart TD
A[Start buildAuthUrl] --> B[Set base params client_id, redirect_uri, response_type, state]
B --> C{Is signupKind apple}
C -->|Yes| D[Do not include scope parameter]
C -->|No| E[Add scope openid profile email]
D --> F[Build OAuth URL with current params]
E --> F[Build OAuth URL with current params]
F --> G[Return OAuth URL]
File-Level Changes
| Change | Details | Files |
|---|---|---|
| Adjust OAuth authorization URL construction to omit scope for Apple signups and update associated tests. |
|
packages/wallet/wdk/src/sequence/handlers/authcode.tspackages/wallet/wdk/test/authcode.test.ts |
| Expand the dapp-client public API surface to include additional transport-related types and enums. |
|
packages/wallet/dapp-client/src/index.ts |
| Version bump multiple packages to 3.0.0-beta.8 and document Apple auth fixes and dependency updates in changelogs and changesets. |
|
packages/wallet/wdk/CHANGELOG.mdpackages/wallet/dapp-client/CHANGELOG.mdpackages/wallet/core/CHANGELOG.mdpackages/services/relayer/CHANGELOG.mdpackages/services/api/CHANGELOG.mdpackages/services/builder/CHANGELOG.mdpackages/services/guard/CHANGELOG.mdpackages/services/identity-instrument/CHANGELOG.mdpackages/services/indexer/CHANGELOG.mdpackages/services/marketplace/CHANGELOG.mdpackages/services/metadata/CHANGELOG.mdpackages/services/userdata/CHANGELOG.mdpackages/utils/abi/CHANGELOG.mdpackages/wallet/primitives/CHANGELOG.mdpackages/services/api/package.jsonpackages/services/builder/package.jsonpackages/services/guard/package.jsonpackages/services/identity-instrument/package.jsonpackages/services/indexer/package.jsonpackages/services/marketplace/package.jsonpackages/services/metadata/package.jsonpackages/services/relayer/package.jsonpackages/services/userdata/package.jsonpackages/utils/abi/package.jsonpackages/wallet/core/package.jsonpackages/wallet/dapp-client/package.jsonpackages/wallet/primitives/package.jsonpackages/wallet/wdk/package.json.changeset/new-turkeys-double.md.changeset/nice-tips-slide.md.changeset/pre.json |
Tips and commands
Interacting with Sourcery
- Trigger a new review: Comment
@sourcery-ai reviewon the pull request. - Continue discussions: Reply directly to Sourcery's review comments.
- Generate a GitHub issue from a review comment: Ask Sourcery to create an
issue from a review comment by replying to it. You can also reply to a
review comment with@sourcery-ai issueto create an issue from it. - Generate a pull request title: Write
@sourcery-aianywhere in the pull
request title to generate a title at any time. You can also comment
@sourcery-ai titleon the pull request to (re-)generate the title at any time. - Generate a pull request summary: Write
@sourcery-ai summaryanywhere in
the pull request body to generate a PR summary at any time exactly where you
want it. You can also comment@sourcery-ai summaryon the pull request to
(re-)generate the summary at any time. - Generate reviewer's guide: Comment
@sourcery-ai guideon the pull
request to (re-)generate the reviewer's guide at any time. - Resolve all Sourcery comments: Comment
@sourcery-ai resolveon the
pull request to resolve all Sourcery comments. Useful if you've already
addressed all the comments and don't want to see them anymore. - Dismiss all Sourcery reviews: Comment
@sourcery-ai dismisson the pull
request to dismiss all existing Sourcery reviews. Especially useful if you
want to start fresh with a new review - don't forget to comment
@sourcery-ai reviewto trigger a new review!
Customizing Your Experience
Access your dashboard to:
- Enable or disable review features such as the Sourcery-generated pull request
summary, the reviewer's guide, and others. - Change the review language.
- Add, remove or edit custom review instructions.
- Adjust other review settings.
Getting Help
- Contact our support team for questions or feedback.
- Visit our documentation for detailed guides and information.
- Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.
Originally posted by @sourcery-ai[bot] in #199 (comment)
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
dependenciesPull requests that update a dependency filePull requests that update a dependency filedocumentationImprovements or additions to documentationImprovements or additions to documentationduplicateThis issue or pull request already existsThis issue or pull request already existsenhancementNew feature or requestNew feature or requestgood first issueGood for newcomersGood for newcomershelp wantedExtra attention is neededExtra attention is neededinvalidThis doesn't seem rightThis doesn't seem rightjavascriptPull requests that update javascript codePull requests that update javascript codequestionFurther information is requestedFurther information is requested
Projects
Status
Done
Status
Done