-
Notifications
You must be signed in to change notification settings - Fork 1
Update codecov.yml (#67) #69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 41-vercelbot
Are you sure you want to change the base?
Conversation
Signed-off-by: AU_gdev_19 <64915515+Dargon789@users.noreply.github.com>
Signed-off-by: AU_gdev_19 <64915515+Dargon789@users.noreply.github.com>
…tion Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com> Signed-off-by: AU_gdev_19 <64915515+Dargon789@users.noreply.github.com>
Signed-off-by: AU_gdev_19 <64915515+Dargon789@users.noreply.github.com>
…ain permissions Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com> Signed-off-by: AU_gdev_19 <64915515+Dargon789@users.noreply.github.com>
Signed-off-by: AU_gdev_19 <64915515+Dargon789@users.noreply.github.com>
Signed-off-by: AU_gdev_19 <64915515+Dargon789@users.noreply.github.com>
* Update codecov.yml Signed-off-by: AU_gdev_19 <64915515+Dargon789@users.noreply.github.com> * Update codecov.yml Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com> Signed-off-by: AU_gdev_19 <64915515+Dargon789@users.noreply.github.com> --------- Signed-off-by: AU_gdev_19 <64915515+Dargon789@users.noreply.github.com> Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com>
Signed-off-by: AU_gdev_19 <64915515+Dargon789@users.noreply.github.com>
* Update config.yml Signed-off-by: AU_gdev_19 <64915515+Dargon789@users.noreply.github.com> * Update .circleci/config.yml Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com> Signed-off-by: AU_gdev_19 <64915515+Dargon789@users.noreply.github.com> --------- Signed-off-by: AU_gdev_19 <64915515+Dargon789@users.noreply.github.com> Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com>
CI: Introduce .github/dependabot.yml to configure weekly dependency updates for the repository Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com>
Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com>
New Features: Create dependabot.yml to configure automated weekly dependency updates Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com>
Bumps the npm_and_yarn group with 7 updates in the / directory: | Package | From | To | | --- | --- | --- | | [lockfile-lint-api](https://github.com/lirantal/lockfile-lint/tree/HEAD/packages/lockfile-lint-api) | `5.8.0` | `5.9.2` | | [body-parser](https://github.com/expressjs/body-parser) | `1.20.2` | `1.20.3` | | [ws](https://github.com/websockets/ws) | `8.16.0` | `8.18.3` | | [brace-expansion](https://github.com/juliangruber/brace-expansion) | `1.1.11` | `1.1.12` | | [braces](https://github.com/micromatch/braces) | `3.0.2` | `3.0.3` | | [rollup](https://github.com/rollup/rollup) | `2.79.1` | `2.79.2` | | [playwright](https://github.com/microsoft/playwright) | `1.36.1` | `1.56.1` | Updates `lockfile-lint-api` from 5.8.0 to 5.9.2 - [Release notes](https://github.com/lirantal/lockfile-lint/releases) - [Changelog](https://github.com/lirantal/lockfile-lint/blob/main/packages/lockfile-lint-api/CHANGELOG.md) - [Commits](https://github.com/lirantal/lockfile-lint/commits/lockfile-lint-api@5.9.2/packages/lockfile-lint-api) Updates `body-parser` from 1.20.2 to 1.20.3 - [Release notes](https://github.com/expressjs/body-parser/releases) - [Changelog](https://github.com/expressjs/body-parser/blob/master/HISTORY.md) - [Commits](expressjs/body-parser@1.20.2...1.20.3) Updates `ws` from 8.16.0 to 8.18.3 - [Release notes](https://github.com/websockets/ws/releases) - [Commits](websockets/ws@8.16.0...8.18.3) Updates `brace-expansion` from 1.1.11 to 1.1.12 - [Release notes](https://github.com/juliangruber/brace-expansion/releases) - [Commits](juliangruber/brace-expansion@1.1.11...v1.1.12) Updates `braces` from 3.0.2 to 3.0.3 - [Changelog](https://github.com/micromatch/braces/blob/master/CHANGELOG.md) - [Commits](micromatch/braces@3.0.2...3.0.3) Updates `rollup` from 2.79.1 to 2.79.2 - [Release notes](https://github.com/rollup/rollup/releases) - [Changelog](https://github.com/rollup/rollup/blob/master/CHANGELOG-2.md) - [Commits](rollup/rollup@v2.79.1...v2.79.2) Updates `playwright` from 1.36.1 to 1.56.1 - [Release notes](https://github.com/microsoft/playwright/releases) - [Commits](microsoft/playwright@v1.36.1...v1.56.1) Updates `tar-fs` from 2.1.1 to 3.0.4 - [Commits](mafintosh/tar-fs@v2.1.1...v3.0.4) --- updated-dependencies: - dependency-name: lockfile-lint-api dependency-version: 5.9.2 dependency-type: direct:development dependency-group: npm_and_yarn - dependency-name: body-parser dependency-version: 1.20.3 dependency-type: direct:production dependency-group: npm_and_yarn - dependency-name: ws dependency-version: 8.18.3 dependency-type: direct:development dependency-group: npm_and_yarn - dependency-name: brace-expansion dependency-version: 1.1.12 dependency-type: indirect dependency-group: npm_and_yarn - dependency-name: braces dependency-version: 3.0.3 dependency-type: indirect dependency-group: npm_and_yarn - dependency-name: rollup dependency-version: 2.79.2 dependency-type: indirect dependency-group: npm_and_yarn - dependency-name: playwright dependency-version: 1.56.1 dependency-type: indirect dependency-group: npm_and_yarn - dependency-name: tar-fs dependency-version: 3.0.4 dependency-type: indirect dependency-group: npm_and_yarn ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
|
|
Reviewer's GuideThis PR consolidates and enhances CI workflows across GitHub Actions and CircleCI, introduces dynamic test matrices for VM and blockchain forks, refines code scanning and coverage settings, adds Dependabot support, and updates key project dependencies. Flow diagram for dynamic VM and blockchain test matrices in CIflowchart TD
Start["Start VM Workflow"]
MatrixCheck["Check for 'Test all hardforks' label"]
ForkMatrix["Run tests for forks: Berlin, London, Paris, Shanghai, Cancun"]
ExtendedForkMatrix["Run extended tests for all hardforks"]
BlockchainMatrix["Run blockchain tests for forks: Berlin, London, Paris, Shanghai, Cancun"]
BlockchainExtendedMatrix["Run extended blockchain tests for all hardforks and transitions"]
End["End Workflow"]
Start --> MatrixCheck
MatrixCheck -- No label --> ForkMatrix
MatrixCheck -- No label --> BlockchainMatrix
MatrixCheck -- Label present --> ExtendedForkMatrix
MatrixCheck -- Label present --> BlockchainExtendedMatrix
ForkMatrix --> End
ExtendedForkMatrix --> End
BlockchainMatrix --> End
BlockchainExtendedMatrix --> End
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
|
| Status | Scanner | Total (0) | ||||
|---|---|---|---|---|---|---|
| Open Source Security | 0 | 0 | 0 | 0 | See details |
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.
Summary of ChangesHello @Dargon789, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on enhancing the project's continuous integration, code quality, and dependency management infrastructure. It introduces a more tailored CircleCI setup, integrates Dependabot for automated dependency updates, and significantly upgrades the Codecov configuration for more precise and integrated coverage reporting. Additionally, it includes routine dependency updates and a minor improvement to test file filtering for increased robustness. Highlights
Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey there - I've reviewed your changes - here's some feedback:
- The vm-build workflow has become very large and repetitive—consider refactoring common steps into a reusable workflow or composite action to reduce duplication and improve maintainability.
- Pulling in all of lodash just for escapeRegExp seems heavy; consider inlining a small regex‐escape helper or using a more lightweight utility instead.
- The
if: contains(join(...), 'Test all hardforks')label check is a bit brittle—using a dedicated action or the built-inlabelscontext to match labels more explicitly might be more reliable.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The vm-build workflow has become very large and repetitive—consider refactoring common steps into a reusable workflow or composite action to reduce duplication and improve maintainability.
- Pulling in all of lodash just for escapeRegExp seems heavy; consider inlining a small regex‐escape helper or using a more lightweight utility instead.
- The `if: contains(join(...), 'Test all hardforks')` label check is a bit brittle—using a dedicated action or the built-in `labels` context to match labels more explicitly might be more reliable.
## Individual Comments
### Comment 1
<location> `.github/dependabot.yml:8` </location>
<code_context>
+
+version: 2
+updates:
+ - package-ecosystem: "" # See documentation for possible values
+ directory: "/" # Location of package manifests
+ schedule:
</code_context>
<issue_to_address>
**issue (bug_risk):** The package-ecosystem field is left empty, which will prevent Dependabot from functioning.
Specify a valid package-ecosystem value (e.g., 'npm', 'yarn', 'docker') to ensure Dependabot can perform updates.
</issue_to_address>
### Comment 2
<location> `.github/workflows/dependabot.yml:8` </location>
<code_context>
+
+version: 2
+updates:
+ - package-ecosystem: "" # See documentation for possible values
+ directory: "/" # Location of package manifests
+ schedule:
</code_context>
<issue_to_address>
**issue (bug_risk):** The package-ecosystem field is empty, which will prevent Dependabot from running.
Update the package-ecosystem field with the appropriate value for your project's package manager.
</issue_to_address>
### Comment 3
<location> `.github/workflows/vm-build.yml:67` </location>
<code_context>
- test-vm-blockchain:
+ vm-state-extended:
+ if: contains(join(github.event.pull_request.labels.*.name, ' '), 'Test all hardforks')
runs-on: ubuntu-latest
+ strategy:
</code_context>
<issue_to_address>
**suggestion:** The conditional for extended jobs relies on a specific label string, which may be brittle.
If the label is missing or slightly different, the jobs will be skipped. Please make the label check more flexible or clearly document the required label for contributors.
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the Codecov configuration, adds a Dependabot configuration, updates several dependencies, and refactors the CircleCI pipeline. While the changes to codecov.yml and most dependency updates are fine, there are a few issues that need attention. The new Dependabot configuration is invalid because it's missing the package-ecosystem. The CircleCI configuration contains a hardcoded URL from another project and uses an unconventional job name. Additionally, the lodash dependency has been added to production dependencies but is only used for testing, and could potentially be replaced with a small helper function to avoid a new dependency.
…ain permissions (#64) Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com> Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com>
* Update issue templates * Update .github/ISSUE_TEMPLATE/bug_report.md Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com> * Update .github/ISSUE_TEMPLATE/custom.md Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com> * Update .github/ISSUE_TEMPLATE/feature_request.md Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com> --------- Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com> Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Summary by Sourcery
Revise CI/CD configurations across GitHub workflows, CircleCI, and Codecov, add Dependabot updates, and fix a regex escaping issue in tx tests
Bug Fixes:
Enhancements:
CI:
Chores: