Skip to content

Conversation

@Dargon789
Copy link
Owner

@Dargon789 Dargon789 commented Oct 23, 2025

Summary by Sourcery

CI:

  • Enable flag_coverage_not_uploaded_behavior as include in codecov.yml

Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com>
@bolt-new-by-stackblitz
Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Oct 23, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR modifies the Codecov configuration to include unuploaded coverage flags by updating the default behavior in codecov.yml.

File-Level Changes

Change Details Files
Change default behavior for missing coverage flags
  • Updated flag_coverage_not_uploaded_behavior from 'exclude' to 'include'
codecov.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@snyk-io
Copy link

snyk-io bot commented Oct 23, 2025

Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @Dargon789, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request adjusts the Codecov configuration to modify how missing coverage reports are handled. By changing the flag_coverage_not_uploaded_behavior setting, the system will now include the absence of coverage reports in its status calculations, aiming to enforce more comprehensive coverage reporting across all defined flags.

Highlights

  • Codecov Configuration Update: The codecov.yml file has been updated to change the flag_coverage_not_uploaded_behavior from exclude to include. This modification means that if coverage reports for a specific flag are not uploaded, they will now be factored into the overall coverage status calculation, potentially causing the status to fail if expected coverage is not met.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes - here's some feedback:

  • Add a brief inline note in codecov.yml explaining the intent behind switching flag_coverage_not_uploaded_behavior to include for future reference.
  • Verify that all CI jobs reliably upload coverage reports under the new include setting to prevent misleading coverage metrics when data is missing.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- Add a brief inline note in codecov.yml explaining the intent behind switching flag_coverage_not_uploaded_behavior to include for future reference.
- Verify that all CI jobs reliably upload coverage reports under the new include setting to prevent misleading coverage metrics when data is missing.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the Codecov configuration to be stricter about missing coverage reports for flags. This is a positive change for code quality enforcement. My review includes a comment highlighting a potential side effect of this change on optional CI jobs and suggests how to handle it. For future pull requests, especially configuration changes, I recommend adding a description to explain the reasoning behind the changes.

@Dargon789 Dargon789 merged commit a57fc82 into master Oct 23, 2025
61 of 65 checks passed
@Dargon789 Dargon789 deleted the Dargon789-patch-1 branch October 23, 2025 18:07
Dargon789 added a commit that referenced this pull request Oct 23, 2025
Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com>
@Dargon789 Dargon789 linked an issue Oct 24, 2025 that may be closed by this pull request
Dargon789 added a commit that referenced this pull request Oct 24, 2025
#66)

* Potential fix for code scanning alert no. 997: Workflow does not contain permissions (#64)

Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>

* Update codecov.yml (#67)

Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com>

* Update codeql.yml (#71)

Chores:

Fix blank line indentation in .github/workflows/codeql.yml

Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com>

---------

Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Dargon789 added a commit that referenced this pull request Oct 25, 2025
* Delete .github/dependabot.yml

Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com>

* Potential fix for code scanning alert no. 997: Workflow does not contain permissions (#64)

Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>

* Update codecov.yml (#67)

Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com>

* Update codeql.yml (#71)

Chores:

Fix blank line indentation in .github/workflows/codeql.yml

Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com>

* Potential fix for code scanning alert no. 67: Workflow does not contain permissions (#74)

To fix this issue, add a permissions block with least privilege at the root level of the workflow (just after the name: or the on: block), or scoped to the test-tx job if different jobs have distinct needs. For this workflow, since it primarily checks out code, installs dependencies, runs lint, coverage, and pushes coverage data (to Codecov, not back to GitHub), it only requires read access to repository contents. Thus, set permissions: contents: read at the workflow level, which restricts the GITHUB_TOKEN in all jobs unless overridden.

Edit .github/workflows/tx-build.yml:

Insert the following under the name: Tx line (before on:):
permissions:
  contents: read
No method, import, or other code is needed; this is a pure configuration change.

Suggested fixes powered by Copilot Autofix. Review carefully before merging.

Summary by Sourcery
CI:

Add permissions.contents: read at the root of .github/workflows/tx-build.yml to grant only read access to repository contents

--------------------

#74 (comment)

--------------------

#74 (comment)

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.13%. Comparing base (ff99c86) to head (c4fd07e).
⚠️ Report is 8 commits behind head on master.

Additional details and impacted files
🚀 New features to boost your workflow:
❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

--------------------------------
Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>

---------

Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
@Dargon789 Dargon789 linked an issue Oct 29, 2025 that may be closed by this pull request
Dargon789 added a commit that referenced this pull request Nov 11, 2025
Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

#### Flow diagram for dynamic VM and blockchain test matrices in CI ethereum-master

2 participants