Skip to content

Fix paths argument handling #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Daniel-Marynicz merged 2 commits into from
Jul 18, 2025
Merged

Fix paths argument handling #75

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cc46963
Fix `paths` argument handling
Jul 17, 2025
065a268
Add string case in `paths` argument handling
Jul 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 18 additions & 4 deletions src/Cli/ParallelController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,12 +193,26 @@ private function startPoll(): void
*/
private function createTasks()
{
$path = $this->input->hasArgument('paths') ? $this->input->getArgument('paths') : null;
if (! is_string($path) && $path !== null) {
throw new UnexpectedValue('Expected string or null');
$paths = $this->input->hasArgument('paths') ? $this->input->getArgument('paths') : null;

if (is_null($paths) || is_string($paths)) {
return $this->taskFactory->createTasks($this->input, $paths);
}

if (!is_array($paths)) {
throw new UnexpectedValue('Expected array, string or null');
}

if (empty($paths)) {
return $this->taskFactory->createTasks($this->input, null);
}

$tasks = [];
foreach ($paths as $path) {
$tasks = array_merge($tasks, $this->taskFactory->createTasks($this->input, $path));
}

return $this->taskFactory->createTasks($this->input, $path);
return $tasks;
}

/**
Expand Down
Loading