Fix paths argument handling#75
Merged
Daniel-Marynicz merged 2 commits intoDaniel-Marynicz:mainfrom Jul 18, 2025
Merged
Conversation
Daniel-Marynicz
requested changes
Jul 17, 2025
Owner
Daniel-Marynicz
left a comment
Daniel-Marynicz
left a comment
There was a problem hiding this comment.
In some older versions of behat, this parameter was a string. You need to maintain support for this string to make this backward compatible.
src/Cli/ParallelController.php
Outdated
| if (! is_string($path) && $path !== null) { | ||
| throw new UnexpectedValue('Expected string or null'); | ||
| $paths = $this->input->hasArgument('paths') ? $this->input->getArgument('paths') : null; | ||
| if (!is_array($paths) && $paths !== null) { |
Owner
There was a problem hiding this comment.
In some older versions of behat, this parameter was a string. You need to maintain support for this string to make this backward compatible.
|
@Daniel-Marynicz are you going to make a new release with this? |
Owner
|
I have released a new version 1.1.0. Before that, I did not have time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous fix introduced by @das-peter actually broke the extension, as
pathsargument is array type by default and now extension won't even start (I did check with a fresh symfony+behat+extension project, setup as described in README.md). So here is the actual fix to supportpathsinstead ofpath.