-
Notifications
You must be signed in to change notification settings - Fork 62
tr_font: no need for file extension #1803
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
It might be good to use a name that can't conflict with / is distinct from normal file names. Like for the RmlUi font textures we have |
That's doable. I guess it was named like this because in the past it could be a generated image in the pk3. There are comments about it. But it was tied to some limitations we don't have if I'm right. |
I discovered that |
OK, that makes some sense, it's fine as is. |
Actually no, the code is confusing but it doesn't look like there would be any way to use an image from a pak instead of rendering using Freetype. I think I changed that behavior recently; before it might have been possible to do an image lookup for that function. But that could only happen after the glyph was already rendered with Freetype. It seems clearly wrong to render something and then discard it so I prevented that lookup from happening. |
I believe we have no reason to load such file from pk3/dpk anymore, so I'm OK with making the name using some internal naming scheme, but then we must clean-up anything about loading such file from the VFS. |
OK, if you find anything to clean up go ahead. Regarding pre-rasterized fonts I'm only aware of the code loading |
Not only our builtin image detector doesn't check for paths starting with |
But is the image generated by |
A shader is created using the image and the shader handle is stored. |
I did it for log æsthetics, but it fixes
testshader fonts/unifont_0_0_32
as an unexpected side effect.We always use an explicit format as
internalFormat
everywhere else.