report game version in userinfo #1767
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe it would be beneficial to report the game version in the userinfo, this will help server admins troubleshoot issues when players are reporting problems with the game. There will be a separate PR for the
/versions
command insg_admin.cpp
which will allow admins to view this information.Some Tremulous clients had this feature, I am simply bringing that here (notably Tremfusion did this).
I also believe we should be reporting the build short commit hash in the version string, which will allow server admins to understand which exact build a player is using, but I believe that should be done in another PR.
CC: @illwieckz and @VReaperV