-
Notifications
You must be signed in to change notification settings - Fork 63
Add translucent solid option for showing culling bbox #1674
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Isn't that what |
cg_drawbbox is for the collision bounding box used by gamelogic. This is for the culling bounding box used by the renderer. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are the alpha channel changes in colours needed?
For RT_SPRITE entities the bounds are not valid and it would draw something using garbage data from a previous entity. Skip anything that is not RT_MODEL.
Sometimes I look directly at a door and its bbox is not shown. Looks like ent->cull is only used for IQM/MD5/MD3 models.
It was pointless since it was only read immediately after being written.
Rename r_showEntityTransforms to r_showEntityBounds and add a new option (2) for showing the culling bounding boxes as a solid translucent surface, in addition to the old wireframe option. This makes it easier to see when the model is poking out of the box.
I added polygon offset so those ones that are flush with the bbox will look better.
This was a pre-existing bug that some nonexistent entities were drawn using uninitialized data. Now fixed by Also fixed another pre-existing bug where entities were culled (from bbox drawing) that shouldn't have been. |
alphagen vertex doesn't work right if the uniform is not 0. |
Rename r_showEntityTransforms to r_showEntityBounds and add a new option (2) for showing the culling bounding boxes as a solid translucent surface, in addition to the old wireframe option. This makes it easier to see when the model is poking out of the box.