Skip to content

Fix copy-paste error #1661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 6, 2025
Merged

Fix copy-paste error #1661

merged 1 commit into from
May 6, 2025

Conversation

VReaperV
Copy link
Contributor

@VReaperV VReaperV commented May 5, 2025

No description provided.

@VReaperV VReaperV added the T-Bug label May 5, 2025
@slipher
Copy link
Member

slipher commented May 5, 2025

LGTM I guess.

I don't think that can happen anyway as fogs only occur as part of a BSP, so they can't be an MD3 surface.

@VReaperV
Copy link
Contributor Author

VReaperV commented May 5, 2025

I don't think that can happen anyway as fogs only occur as part of a BSP, so they can't be an MD3 surface.

They actually can, they just use R_FogWorldBox() to get the fogNum. E. g. for MD3:

fogNum = R_FogWorldBox( ent->worldBounds );

Without this change some maps crash in ProcessShaderFog() if the heatHaze shader is not loaded.

@VReaperV VReaperV merged commit 3079161 into DaemonEngine:master May 6, 2025
9 checks passed
@VReaperV VReaperV deleted the fix-error branch May 6, 2025 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants