only include active roles in plan share tab; don't take inactive role…#2954
Merged
raycarrick-ed merged 1 commit intoDMPRoadmap:developmentfrom Jun 25, 2021
nicolasfranck:fix_issue_2951
Merged
only include active roles in plan share tab; don't take inactive role…#2954raycarrick-ed merged 1 commit intoDMPRoadmap:developmentfrom nicolasfranck:fix_issue_2951
raycarrick-ed merged 1 commit intoDMPRoadmap:developmentfrom
nicolasfranck:fix_issue_2951
Conversation
…s into account on creation
briri
approved these changes
Jun 24, 2021
Contributor
briri
left a comment
briri
left a comment
There was a problem hiding this comment.
This looks good to me. Thanks @nicolasfranck
| <h2><%= _('Manage collaborators')%></h2> | ||
| <p><%= _('Invite specific people to read, edit, or administer your plan. Invitees will receive an email notification that they have access to this plan.') %></p> | ||
| <% if @plan.roles.any? then %> | ||
| <% if @plan_roles.any? then %> |
raycarrick-ed
approved these changes
Jun 25, 2021
portagenetwork
pushed a commit
to portagenetwork/roadmap
that referenced
this pull request
Feb 24, 2022
only include active roles in plan share tab; don't take inactive role…
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2951
Comments:
@plan_rolesinPlansController#request_feedback, but that variables isn't used anywhere?