Merged
Conversation
Pull in org selection work
latest roadmap changes
briri
approved these changes
Apr 9, 2021
Contributor
briri
left a comment
briri
left a comment
There was a problem hiding this comment.
Looks good @raycarrick-ed thanks for catching/patching this
Contributor
|
Looks like a minor rubocop issue with extra spaces. Once that's updated feel free to merge yourself 👍🏻 |
portagenetwork
pushed a commit
to portagenetwork/roadmap
that referenced
this pull request
Feb 24, 2022
Share plan org
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When sharing a plan with a new user, when the new user followed the link in the invitation email and filled in the new user form, they got an "org needs set" error because the org params coming back to devise where not as needed.
This adds a before-action to fix up the params for devise.