-
Notifications
You must be signed in to change notification settings - Fork 0
[Refactor] 1차 QA 반영 #88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
fca9f48
[refactor] #87 Apply BADGE enum class
t1nm1ksun e8561fb
[refactor] #87 date 서버응답 반영
t1nm1ksun 32a4b6a
[refactor] #87 상세화면 badge 전달
t1nm1ksun 713a9a5
[refactor] #87 홈 북마크 위치 고정
t1nm1ksun 9ae0516
[refactor] #87 홈 뷰모델 init으로 초기 데이터 로드
t1nm1ksun acfaca0
[refactor] #87 오늘 노래가 3개여도 잠금 ui 표시
t1nm1ksun 10b9e31
[refactor] #87 잠금 앨범 모달 추가
t1nm1ksun 48fe881
[feat] #87 상세화면 글 삭제 확인 모달 추가
t1nm1ksun 95dc714
[feat] #87 글 등록/삭제 후 홈 데이터 새로고침
t1nm1ksun 1ad2e0e
[feat] #87 노래제목, 가수 한줄제한추가
t1nm1ksun 50238c1
[feat] #87 북마크 스낵바 네비게이션 연결
t1nm1ksun 2f93cc6
[feat] #87 신고하기 바텀시 단일선택, 버튼 활성화 로직 추가
t1nm1ksun 65d9593
[feat] #87 마이페이지 탭 유지 로직 추가
t1nm1ksun fc1d649
[feat] #87 홈 새로고침시 첫번쨰 노래로 이동
t1nm1ksun 47b1bc5
ktlint Format
t1nm1ksun 5228963
[feat] #87 과거 추천 기록 노래 리스트 아이템 미트볼 버튼 삭제
t1nm1ksun File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
16 changes: 16 additions & 0 deletions
16
core/common/src/main/java/com/example/common/event/HomeRefreshTrigger.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| package com.example.common.event | ||
|
|
||
| import kotlinx.coroutines.flow.MutableSharedFlow | ||
| import kotlinx.coroutines.flow.asSharedFlow | ||
| import javax.inject.Inject | ||
| import javax.inject.Singleton | ||
|
|
||
| @Singleton | ||
| class HomeRefreshTrigger | ||
| @Inject | ||
| constructor() { | ||
| private val _refreshEvent = MutableSharedFlow<Unit>() | ||
| val refreshEvent = _refreshEvent.asSharedFlow() | ||
|
|
||
| suspend fun refresh() = _refreshEvent.emit(Unit) | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 changes: 7 additions & 6 deletions
13
core/domain/src/main/java/com/example/domain/model/FeedItem.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,17 +1,18 @@ | ||
| package com.example.domain.model | ||
|
|
||
|
|
||
| data class FeedItem( | ||
| val postId: Long, | ||
| val isScrapped: Boolean, | ||
| val content: String, | ||
| val badges: Badges, | ||
| val badge: BADGE?, | ||
| val track: Track, | ||
| val writer: Writer, | ||
| val like: Like, | ||
| ) | ||
|
|
||
| data class Badges( | ||
| val isEditorPick: Boolean, | ||
| val isPopular: Boolean, | ||
| val isNew: Boolean, | ||
| ) | ||
| enum class BADGE { | ||
| EDITOR, | ||
| BEST, | ||
| NEW, | ||
| } |
12 changes: 11 additions & 1 deletion
12
core/domain/src/main/java/com/example/domain/model/PostDetail.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,11 +1,21 @@ | ||
| package com.example.domain.model | ||
|
|
||
| import java.time.LocalDate | ||
| import java.time.format.DateTimeFormatter | ||
|
|
||
| data class PostDetail( | ||
| val postId: Long, | ||
| val isHost: Boolean, | ||
| val isScrapped: Boolean, | ||
| val content: String, | ||
| private val date: String, | ||
| val track: Track, | ||
| val writer: Writer, | ||
| val like: Like, | ||
| ) | ||
| ) { | ||
| val displayDate: String | ||
| get() = runCatching { | ||
| val parsedDate = LocalDate.parse(date, DateTimeFormatter.ISO_DATE) | ||
| "${parsedDate.monthValue}월 ${parsedDate.dayOfMonth}일" | ||
| }.getOrElse { "알 수 없는 날짜" } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
오우 이게 event bus 패턴인가요