Conversation
kamja0510
approved these changes
Jan 27, 2026
Collaborator
kamja0510
left a comment
kamja0510
left a comment
There was a problem hiding this comment.
구현 자체는 문제없는 것 같습니다!
고생띠
|
|
||
| data object NavigateToMyPage : HomeSideEffect | ||
|
|
||
| data object ScrollToFirstPage : HomeSideEffect |
Collaborator
There was a problem hiding this comment.
사이드 이펙트로 처리하게 된 이유가 뭔가요?
| } | ||
|
|
||
| companion object { | ||
| private val lockedDummyFeedItem = |
Collaborator
There was a problem hiding this comment.
viewmodel에서 더미 데이터는 지우는 것이 좋을 것 같습니다. repository와 연동한 시점에서는 가짜 Repository 구현체를 만들어서 테스트 하는 방식이 관심사 분리 측면에서 더 좋다고 생각합니다.
| val like: Like, | ||
| ) | ||
|
|
||
| enum class BADGE { |
Collaborator
There was a problem hiding this comment.
kotlin 에서 enum class의 네이밍 컨벤션은 파스칼 케이스로 알고 있습니다
| import javax.inject.Singleton | ||
|
|
||
| @Singleton | ||
| class HomeRefreshTrigger |
| viewModel: MyPageViewModel = hiltViewModel(), | ||
| ) { | ||
| val state by viewModel.uiState.collectAsStateWithLifecycle() | ||
| var hasAppliedInitialTab by rememberSaveable { mutableStateOf(false) } |
Collaborator
There was a problem hiding this comment.
이 변수가contract가 아닌 screen 파일에 있는 이유가 있을까요?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue 🛠
Work Description ✏️
Home
Detail
MyPage
BottomSheet
Record
Common
Screenshot 📸
Uncompleted Tasks 😅
To Reviewers 📢
커밋 기준으로 변경사항 확인하시면 좋을 것 같아요~