Skip to content

refactor: streamline hash compare 2 #780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 12, 2025
Merged

refactor: streamline hash compare 2 #780

merged 1 commit into from
Feb 12, 2025

Conversation

jkowalleck
Copy link
Member

No description provided.

@jkowalleck
refactor: streamline comparisson and hashing
7408eaf 
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck jkowalleck requested a review from a team as a code owner February 12, 2025 16:30
@jkowalleck jkowalleck changed the base branch from main to 9.0.0-dev February 12, 2025 16:30
@jkowalleck jkowalleck changed the title Feat/streamline hash compare 2 refactor: streamline hash compare 2 Feb 12, 2025
@jkowalleck jkowalleck mentioned this pull request Feb 12, 2025
Merged
5 tasks
@codacy-production Codacy Production
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for 82e0bb11 ✅ 84.85% (target: 80.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (82e0bb1) Report Missing Report Missing Report Missing
Head commit (7408eaf) 5187 4855 93.60%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#780) 264 224 84.85%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Footnotes

  1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct. ↩

@codacy-production Codacy Production
Copy link

codacy-production bot commented Feb 12, 2025 •
edited
Loading

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
✅ +0.11% ✅ 84.85% (target: 80.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (82e0bb1) 5101 4769 93.49%
Head commit (7408eaf) 5187 (+86) 4855 (+86) 93.60% (+0.11%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#780) 264 224 84.85%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@jkowalleck jkowalleck merged commit cdb5698 into 9.0.0-dev Feb 12, 2025
50 checks passed
@jkowalleck jkowalleck mentioned this pull request Feb 12, 2025
Merged
@jkowalleck jkowalleck deleted the feat/streamline_hash_compare_2 branch February 12, 2025 16:34
@jkowalleck
Copy link
Member Author

A preview of the fix/feature is available via https://github.com/CycloneDX/cyclonedx-python-lib/releases/tag/v9.0.1-rc.1

jkowalleck added a commit that referenced this pull request Feb 26, 2025
@jkowalleck @wkoot
feat!: 9.0.1 (#777)
e6f91fa 
### BREAKING Changes

* Fix: `model.vulnerability.VulnerabilityReference`'s properties are all
mandatory
([#790](#790)
via [#792](#792))
* Refactor: Rename `spdx.is_compund_expression` -> `spdx.is_expression`
([#779](#779))
* Behavior: `BomRef` affects comparison/hashing
([#754](#754) &
[#780](#780))
  This is only a breaking change if you relied on ordering of elements.
* Behavior: streamline comparison/hashing functions
([#755](#755))
  This is only a breaking change if you relied on ordering of elements.
* Dependency: bump dependency `py-serializable >=2 <3`, was `>=1.1.1 <2`
([#775](#775))
This is only a breaking change if you have other packages depend on that
specific version.

---------

Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: wkoot <3715211+wkoot@users.noreply.github.com>
Signed-off-by: semantic-release <semantic-release@bot.local>
Co-authored-by: wkoot <3715211+wkoot@users.noreply.github.com>
Co-authored-by: semantic-release <semantic-release@bot.local>
@jkowalleck
Copy link
Member Author

was released via https://github.com/CycloneDX/cyclonedx-python-lib/releases/tag/v9.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jkowalleck