Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: rename spdx.is_compund_expression -> spdx.is_expression #779

Merged
merged 3 commits into from
Feb 12, 2025

Conversation

jkowalleck
Copy link
Member

fixes #765

Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck jkowalleck requested a review from a team as a code owner February 12, 2025 16:11
@jkowalleck jkowalleck changed the base branch from main to 9.0.0-dev February 12, 2025 16:11
@jkowalleck jkowalleck added this to the 9.0.0 milestone Feb 12, 2025
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck jkowalleck force-pushed the refactor/rename-spdx-is_compound_expression branch from aaaafea to 0103482 Compare February 12, 2025 16:38
@jkowalleck jkowalleck changed the title Refactor/rename spdx is compound expression refactor: rename spdx.is_compund_expression -> spdx.is_expression Feb 12, 2025
@jkowalleck jkowalleck merged commit 8546fb6 into 9.0.0-dev Feb 12, 2025
4 checks passed
@jkowalleck jkowalleck deleted the refactor/rename-spdx-is_compound_expression branch February 12, 2025 16:40
@jkowalleck jkowalleck mentioned this pull request Feb 12, 2025
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% 100.00% (target: 80.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (cdb5698) 5187 4855 93.60%
Head commit (a213628) 5187 (+0) 4855 (+0) 93.60% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#779) 3 3 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@jkowalleck
Copy link
Member Author

A preview of the fix/feature is available via https://github.com/CycloneDX/cyclonedx-python-lib/releases/tag/v9.0.1-rc.1

jkowalleck added a commit that referenced this pull request Feb 26, 2025
### BREAKING Changes

* Fix: `model.vulnerability.VulnerabilityReference`'s properties are all
mandatory
([#790](#790)
via [#792](#792))
* Refactor: Rename `spdx.is_compund_expression` -> `spdx.is_expression`
([#779](#779))
* Behavior: `BomRef` affects comparison/hashing
([#754](#754) &
[#780](#780))
  This is only a breaking change if you relied on ordering of elements.
* Behavior: streamline comparison/hashing functions
([#755](#755))
  This is only a breaking change if you relied on ordering of elements.
* Dependency: bump dependency `py-serializable >=2 <3`, was `>=1.1.1 <2`
([#775](#775))
This is only a breaking change if you have other packages depend on that
specific version.

---------

Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: wkoot <3715211+wkoot@users.noreply.github.com>
Signed-off-by: semantic-release <semantic-release@bot.local>
Co-authored-by: wkoot <3715211+wkoot@users.noreply.github.com>
Co-authored-by: semantic-release <semantic-release@bot.local>
@jkowalleck
Copy link
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SPDX is_compound_expression does not strictly check for compound expression
1 participant