Repository navigation
Audit historical follow-up supplier saving bindings - #3646
Merged
Mister-Meeseeks merged 1 commit intoOct 20, 2026
Merged
Conversation
roger-sato
marked this pull request as ready for review
October 18, 2026 12:46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The historical PR49 arithmetic checker tests supplier moments at
bit.savingandcomplex.savingwithout binding them toassembly.parameters.a_bitanda_complex. This scoped audit reconstructs authenticated historical sources and demonstrates a concrete positive-domain input that prints the ordinary arithmetic PASS at717/20000000, while its unchanged assembly consumes717/10000000. A separate exact rational lower-bound computation proves that the same supplied complex profile has moment greater than1 + 4/10^10at the consumed saving.The counterexample increases the rank-756 multiplicity by five and halves only
complex.saving. Counts are arithmetic inputs, not claimed to be producer-realizable. The original certificate passes its original fixed receipt. The existing--checkreceipt already rejects mutated bytes, so this is not a CI bypass or a counterexample to the original witness. No selected result, production helper, frozen consumer, or source archive changes.The new package includes an opt-in guard for the two rational equalities, a proof of the independent lower bound, and actual CLI controls. The guard accepts equivalent rational spellings and a consistently bound noncontracting profile; the latter is then rejected by the historical arithmetic checker. Binding success alone is not mathematical validation. Production adoption remains an explicitly open next question because existing historical packages bind the live helper bytes.
Task and overlap
20ecf2891d80b5acf18d980b2164fb44ea7faa90; priority revision 6.portable-replay, scope refined from its proof-relevant field-comparison method to supplier/assembly saving comparison. This is a verifier side result, not an environment repair or new construction.VERIFY.json inputs: []. Future changes to the current helper do not have to preserve historical acceptance of the counterexample.Test plan
Python 3.12.14 on macOS arm64, standard library only:
python3.12 -B scripts/research_package.py --package research/followup-supplier-binding-audit --check-onlypython3.12 -B scripts/research_package.py --package research/followup-supplier-binding-audit-O; both printPASS_FOLLOWUP_SUPPLIER_BINDING_AUDIT_ONLY.1 + 4/10^10; no historical numerical routine is imported for this proof.python3.12 -B scripts/check_research_commit.py --package research/followup-supplier-binding-audit --ref HEAD --check-source-historypassed for all seven committed files in a fresh full-history filtered clone of canonical main with the publication commit fetched locally.No finite-count producers, all-package historical suites, Lean, or selected cold replay were run. Source history and arithmetic-input scope are explicit in the README. The package's
TASK.jsonand README describe the smallest production-integration follow-up and its frozen-consumer constraint.Credit
Rohan Arun's PR49 candidate at
f95d2910e027495983b53cae1693cf535abf2569, building on PR48, retains its attribution and original fixed receipt. The historical independent arithmetic checker and PR39 enclosure dependency retain Douglas Colkitt's attribution. Audit and opt-in guard by roger-sato with substantial OpenAI Codex assistance in diagnosis, implementation, exact arithmetic, review, and documentation. Apache-2.0.