Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copied the finishing at the invereted start marker from the combine unloader to the bale finder #3251

Merged
merged 6 commits into from
May 27, 2024

Conversation

schwiti6190
Copy link
Contributor

@schwiti6190 schwiti6190 commented May 20, 2024

#3247

  • Basically the same behaviour as the combine unloader.
  • Test:
    • Check if the different possible bale finder mode like the collector or wrapper or autoload still finish correctly.
    • Also test the new driving to inverted goal marker

@schwiti6190 schwiti6190 changed the title WIP Copied the finishing at the invereted start marker from the combine unloader to the bale finder May 20, 2024
self.vehicle:stopCurrentAIJob(AIMessageErrorIsFull.new())
elseif self:hasBalesLoaded() then
if self.baleLoaderController and self.baleLoaderController:isChangingBaleSize() then
self:debug('There really are no more bales on the field')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this the correct debug text?

self:debug('There really are no more bales on the field')
self.vehicle:stopCurrentAIJob(AIMessageSuccessFinishedJob.new())
else
self:debug('There really are no more bales on the field')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this the correct debug text?

@Tensuko Tensuko merged commit 999d17d into main May 27, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants