fix: [PROD-14470] fix some risks of memory leaks #1046
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR fixes memory leak risks in the PIXI.js graphics rendering system by improving resource cleanup and display object management.
- Introduces comprehensive memory management functions with proper destroy options
- Refactors arrow drawing functions to return graphics objects instead of directly adding to stage
- Updates link graphics creation to use container hierarchy for better memory management
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/views/Simulation/utils/pixiUtils.js | Adds freeDisplayMemory function, refactors drawing functions to arrow functions, and improves link graphics container structure |
| src/views/Simulation/utils/MinimapContainer.js | Adds freeDisplayMemory method and enhances destroy calls with additional cleanup options |
| src/views/Simulation/components/Scene/Scene.js | Replaces inline cleanup logic with centralized freeDisplayMemory function |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
nborde-CSM
force-pushed
the
NBO/fix_memory_leak_when_animation_is_playing_PROD-14740
branch
from
b13bb37 to
f9fa639
Compare
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-sky-06b519003-1046.westeurope.2.azurestaticapps.net |
1 similar comment
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-sky-06b519003-1046.westeurope.2.azurestaticapps.net |
nborde-CSM
force-pushed
the
NBO/fix_memory_leak_when_animation_is_playing_PROD-14740
branch
from
f9fa639 to
9b0dfc2
Compare
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-sky-06b519003-1046.westeurope.2.azurestaticapps.net |
nborde-CSM
force-pushed
the
NBO/fix_memory_leak_when_animation_is_playing_PROD-14740
branch
from
9b0dfc2 to
397047e
Compare
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-sky-06b519003-1046.westeurope.2.azurestaticapps.net |
nborde-CSM
force-pushed
the
NBO/fix_memory_leak_when_animation_is_playing_PROD-14740
branch
3 times, most recently
from
1e79d88 to
05475e0
Compare
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-sky-06b519003-1046.westeurope.2.azurestaticapps.net |
1 similar comment
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-sky-06b519003-1046.westeurope.2.azurestaticapps.net |
nborde-CSM
force-pushed
the
NBO/fix_memory_leak_when_animation_is_playing_PROD-14740
branch
from
05475e0 to
f2aa01a
Compare
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-sky-06b519003-1046.westeurope.2.azurestaticapps.net |
Before creating a PR, please check that:
yarn test)