fix: [PROD-14470] fix some risks of memory leaks

Author: nborde-CSM

src/views/Simulation/components/Scene/Scene.js

@@ -5,7 +5,7 @@ import { useTheme } from '@mui/styles';
 import { useSimulationViewContext } from '../../SimulationViewContext';
 import { DEFAULT_UPDATE_STATE } from '../../SimulationViewHook';
 import { resetGraphHighlighting } from '../../utils/graphUtils';
-import { createApp, destroyApp, initApp, initMinimap, renderElements } from '../../utils/pixiUtils';
+import { createApp, destroyApp, initApp, initMinimap, renderElements, freeDisplayMemory } from '../../utils/pixiUtils';
 import { ChartTimeline } from '../Charts';
 import { Minimap } from './Minimap';
 
@@ -100,11 +100,7 @@ const Scene = () => {
       requiredUpdateStepsRef.current.layout ||
       requiredUpdateStepsRef.current.render
     ) {
-      if (sceneContainerRef.current) {
-        sceneContainerRef.current.removeChildren().forEach((child) => {
-          child.destroy({ children: true, texture: false, baseTexture: false });
-        });
-      }
+      if (sceneContainerRef.current) freeDisplayMemory(sceneContainerRef.current);
 
       const resetBounds = requiredUpdateStepsRef.current.all || requiredUpdateStepsRef.current.layout;
       renderElements(sceneContainerRef, graphRef, setSelectedElementId, settings, resetBounds);

src/views/Simulation/utils/MinimapContainer.js

@@ -17,8 +17,19 @@ export class MinimapContainer extends Container {
     this.dragTarget = null;
   }
 
+  freeDisplayMemory() {
+    this.children.forEach((child) => {
+      child.destroy({
+        children: true,
+        texture: true,
+        context: true,
+        style: true,
+      });
+    });
+  }
+
   renderElements() {
-    this.removeChildren().forEach((child) => child.destroy({ children: true }));
+    this.freeDisplayMemory();
     this.miniSceneContainer = this.forgeContainer(this.sceneContainerRef.current);
 
     this.addChild(this.miniSceneContainer);
@@ -53,7 +64,8 @@ export class MinimapContainer extends Container {
   createScreenCursor() {
     if (this.screenCursor != null) {
       this.removeChild(this.screenCursor);
-      this.screenCursor.destroy({ children: true });
+      this.screenCursor.destroy({ children: true, texture: true, context: true, style: true });
+      this.screenCursor = null;
     }
 
     this.screenCursor = new Graphics();

src/views/Simulation/utils/pixiUtils.js

@@ -411,9 +411,22 @@ const generateTextures = (app) => {
   return textures;
 };
 
+export const freeDisplayMemory = (container) => {
+  container.children.forEach((child) => {
+    child.destroy({
+      children: true,
+      texture: true,
+      context: true,
+      style: true,
+    });
+  });
+};
+
 export const renderElements = (sceneContainerRef, graphRef, setSelectedElementId, settings, resetBounds = true) => {
   if (!graphRef.current || !sceneContainerRef.current?.textures) return;
 
+  freeDisplayMemory(sceneContainerRef.current);
+
   const { nodes, links } = graphRef.current;
   const textures = sceneContainerRef.current.textures;