Skip to content

Clean uneeded test files #392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 27, 2025
Merged

Clean uneeded test files #392

merged 5 commits into from
Mar 27, 2025

Conversation

Manuthor
Copy link
Contributor

No description provided.

@Manuthor Manuthor requested a review from Copilot March 27, 2025 13:10
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes unneeded test files and streamlines dependency configuration and CI workflows.

  • Updates Cargo.toml to pin dependencies for cosmian_findex_server and cosmian_findex_structs using a specific commit revision.
  • Removes the cargo-doc job from the GitHub Actions workflow.

Reviewed Changes

Copilot reviewed 60 out of 78 changed files in this pull request and generated no comments.

File Description
Cargo.toml Replaces branch-based dependency references with commit revisions and includes URL updates.
.github/workflows/main_base.yml Removes the cargo-doc job from the CI configuration.
Files not reviewed (18)
  • .github/scripts/cargo_build.sh: Language not supported
  • cli: Language not supported
  • crate/server/src/tests/google_cse/init_kms_cse.sh: Language not supported
  • test_data/access_structure.json: Language not supported
  • test_data/access_structure_specifications.json: Language not supported
  • test_data/certificates/another_p12/ca.crt: Language not supported
  • test_data/certificates/another_p12/ca.key: Language not supported
  • test_data/certificates/another_p12/ca.srl: Language not supported
  • test_data/certificates/another_p12/generate.sh: Language not supported
  • test_data/certificates/another_p12/intermediate.crt: Language not supported
  • test_data/certificates/another_p12/intermediate.csr: Language not supported
  • test_data/certificates/another_p12/intermediate.key: Language not supported
  • test_data/certificates/another_p12/intermediate.srl: Language not supported
  • test_data/certificates/another_p12/root.crt: Language not supported
  • test_data/certificates/another_p12/root.key: Language not supported
  • test_data/certificates/another_p12/server.crt: Language not supported
  • test_data/certificates/another_p12/server.csr: Language not supported
  • test_data/certificates/another_p12/server.key: Language not supported
Comments suppressed due to low confidence (2)

Cargo.toml:67

cosmian_findex_server = { git = "https://www.github.com/Cosmian/findex-server", rev = "e5044d701b73c75a170f5ff7aaba5cadd8aaed4a" }

.github/workflows/main_base.yml:36

  • Verify that the removal of the cargo-doc job is intentional; if documentation generation is still required on release builds, consider preserving or migrating this step.
-  cargo-doc:

@Manuthor Manuthor merged commit 1a68ee0 into develop Mar 27, 2025
20 of 21 checks passed
@Manuthor Manuthor deleted the ci/fix_rhel9 branch March 27, 2025 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant