feat: add digest and MAC KMIP operations #370
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Manuthor
force-pushed
the
feat/add_digest_and_mac_kmip_operations
branch
from
06fcfc8 to
485e2cf
Compare
Manuthor
force-pushed
the
feat/add_digest_and_mac_kmip_operations
branch
from
55fcf18 to
e1005f7
Compare
Manuthor
force-pushed
the
feat/add_digest_and_mac_kmip_operations
branch
from
ebd2279 to
d71edaa
Compare
tbrezot
reviewed
Feb 24, 2025
crate/cli/src/actions/mac.rs
Outdated
Comment on lines
23
to
24
| SHA512_224, | ||
| SHA512_256, |
There was a problem hiding this comment.
I don't understand what those are. If these are truncations of a hash, I would let this to the user: if you want a short mac, compute a secure one, an truncate it to the desired length (at your own risks).
There was a problem hiding this comment.
if I understand correctly:
- SHA512_* belongs to SHA2 family (with truncation)
- SHA3_belongs to SHA3 family without truncation but extensibility.
Then I will let:
pub enum CHashingAlgorithm {
SHA256,
SHA384,
SHA512,
SHA3_224,
SHA3_256,
SHA3_384,
SHA3_512,
}
| let unique_identifier = UniqueIdentifier::TextString(unique_identifier.to_owned()); | ||
|
|
||
| let hmac = if let Some(correlation_value) = request.correlation_value { | ||
| compute_hmac(&correlation_value, data, algorithm)? |
There was a problem hiding this comment.
What is a correlation value ?
There was a problem hiding this comment.
From KMIP: correlation_value: Specifies the existing stream or by-parts cryptographic operation (as returned from a previous call to this operation).
Manuthor
force-pushed
the
feat/add_digest_and_mac_kmip_operations
branch
from
b097920 to
94fe713
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.