Feat/gmail api insert certs #284
Closed
+882
−42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ccorsin
force-pushed
the
feat/gmail_api_insert_certs
branch
6 times, most recently
from
dad8085 to
107ef6a
Compare
ccorsin
changed the title
tbrezot
reviewed
Jul 25, 2024
There was a problem hiding this comment.
I am not the most suited to validate the business logic of this MR, but I could make some Rust-related comments. The main point: when performing network calls, do not await on the future until you really need it such that parallel calls can be performed (non-blocking I/O is the whole point of Rust async)
Manuthor
reviewed
Jul 26, 2024
ccorsin
force-pushed
the
feat/gmail_api_insert_certs
branch
2 times, most recently
from
6c7dd48 to
76484c1
Compare
ccorsin
force-pushed
the
feat/gmail_api_insert_certs
branch
from
e80bcd5 to
4c29830
Compare
tbrezot
reviewed
Aug 7, 2024
ccorsin
force-pushed
the
feat/gmail_api_insert_certs
branch
2 times, most recently
from
3441fa6 to
c9cb863
Compare
Manuthor
reviewed
Aug 13, 2024
ccorsin
force-pushed
the
feat/gmail_api_insert_certs
branch
2 times, most recently
from
696bf13 to
c1bec42
Compare
Manuthor
force-pushed
the
feat/gmail_api_insert_certs
branch
from
c1bec42 to
17f93ef
Compare
ccorsin
force-pushed
the
feat/gmail_api_insert_certs
branch
from
17f93ef to
2744e07
Compare
Manuthor
reviewed
Aug 30, 2024
ccorsin
force-pushed
the
feat/gmail_api_insert_certs
branch
3 times, most recently
from
a403b2e to
51f0a02
Compare
Manuthor
approved these changes
Aug 30, 2024
ccorsin
force-pushed
the
feat/gmail_api_insert_certs
branch
2 times, most recently
from
3bd5802 to
9b14d84
Compare
ccorsin
force-pushed
the
feat/gmail_api_insert_certs
branch
7 times, most recently
from
9b75f25 to
7da9548
Compare
ccorsin
force-pushed
the
feat/gmail_api_insert_certs
branch
3 times, most recently
from
5db9c50 to
555fea9
Compare
ccorsin
force-pushed
the
feat/gmail_api_insert_certs
branch
from
555fea9 to
520ee45
Compare
ccorsin
force-pushed
the
feat/gmail_api_insert_certs
branch
from
520ee45 to
44eef7c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.