Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RSA benches #251

Merged
merged 5 commits into from
Jun 18, 2024
Merged

RSA benches #251

merged 5 commits into from
Jun 18, 2024

Conversation

bgrieder
Copy link
Contributor

Add RSA benches

@bgrieder bgrieder requested review from Manuthor and tbrezot June 17, 2024 06:48
Copy link
Contributor

@tbrezot tbrezot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, just some allocation that may possibly be moved out of the benched function.

let encrypt_request = build_encryption_request(
pk,
None,
cleartext.to_vec(),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Take ownership instead.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done in f29feec

cleartext.to_vec(),
None,
None,
Some(cryptographic_parameters.clone()),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Take ownership instead.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done in f29feec

@Manuthor Manuthor merged commit 91c05c6 into develop Jun 18, 2024
25 of 26 checks passed
@Manuthor Manuthor deleted the benches branch June 18, 2024 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants