-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validate #247
Conversation
… and modification to indexing
) -> Result<Validate, KmipError> { | ||
let certificates = { | ||
if certificates.is_empty() { | ||
None |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the semantic of this option? Isn't the empty vector enough?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Idk I prefer to deal with Option. I can change if you don't really like it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As you prefer. IMHO, an empty collection is what you want: you can then iterate on it without handling the None
case.
Co-authored-by: Manuthor <32013169+Manuthor@users.noreply.github.com>
How to use gui Certificate validate? |
Hello, ![]() About your certificate, can you confirm the certificate behind your id is DER encoded (not PEM). OpenSSL error gives a format problem. |
hello, |
It passes tests on the server side.
Tests on:
These tests are test the 2 different combos of inputs:
On the client side I am not very sure to how to do it. Anyway, if you could give me a hint would be a big plus.