Feat/cse gmail api #243
Merged
Feat/cse gmail api #243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ccorsin
force-pushed
the
feat/cse_gmail_api
branch
3 times, most recently
from
90e4a2b to
23e7cb6
Compare
ccorsin
force-pushed
the
feat/cse_gmail_api
branch
6 times, most recently
from
e47dc0d to
6f54e62
Compare
Manuthor
reviewed
Apr 30, 2024
There was a problem hiding this comment.
Great job!!
You could update the autogenerated documentation/docs/cli/main_commands.md.
Otherwise I know we are waiting for a work around the Certify operation to be able to generate RSA keys (using specific Openssl extension file): once it will be done, we should get rid off all the p7pem and wrap files and use keys only from memory. I guess we can merge this PR and create a new one later.
Manuthor
approved these changes
Apr 30, 2024
tbrezot
reviewed
Apr 30, 2024
ccorsin
force-pushed
the
feat/cse_gmail_api
branch
3 times, most recently
from
467b292 to
9b00556
Compare
ccorsin
force-pushed
the
feat/cse_gmail_api
branch
from
9b00556 to
3561c62
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.