Make the CLI compile on Windows and MacOS (without openssl installed) #209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bgrieder
changed the title
ThibsG
reviewed
Mar 18, 2024
ThibsG
force-pushed
the
105-removal-of-openssl-in-the-cli
branch
from
eef75fe to
2cd0f6e
Compare
Manuthor
changed the title
ThibsG
approved these changes
Mar 19, 2024
* ci: run binaries in clean env. also in debug mode * ci: increase size of tmp files * ci: test ckms without openssl * ci: test ckms without openssl * ci: fix windows build * ci: only build server just after openssl build * fix(ckms): remove println on CreateKeyPairAction
…res (#218) * fix: make sure to build with features specified in sub-crates Cargo.toml * fix: check if openssl is in ckms-binary-symbols * fix: bump env_logger version * ci: check that ckms does not depend on openssl
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reqwestis switched tonative-tlsso it should not be using openssl on Windows and Macos but will on Linux (so that it can be FIPS compliant server-side)josekitdepends on openssl. Using the vendored openssl version in the client so that theckmscli can build and run on Windows and MacOS without having to install openssl.josekitCloses #105