Reduce stack footprint #200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThibsG
force-pushed
the
reduce_stack_footprint
branch
from
dbd3170 to
b30f5f8
Compare
Merged
ackRow
approved these changes
Mar 7, 2024
|
After a quick read of the diffs, my feelings are mixed: on the one hand, this patch sure should fix the issue; one the other hand, it adds a lot of complexity by exposing the boxing. Moreover, I struggle to see the pattern you followed to decide which object to box. Wouldn't boxing the KMIP |
|
How course, boxing the full I chose to box some elements based on the size they represent in their enum/struct (thank you @ackRow for the reminder 😉). The threshold is totally arbitrary: if the variable is over something like 50 bytes, I did the box. AFAIK there is no magic threshold to choose when to put on the heap |
ackRow
pushed a commit
that referenced
this pull request
Mar 8, 2024
* CI: remove min stack size * Box in Attributes * Box key_wrapping_data and more cryptographic_parameters * Box attributes in KeyValue * Box BigUint and SafeBigUint in KeyMaterial
Manuthor
added a commit
that referenced
this pull request
Mar 8, 2024
* feat: replace attribute rotation to access policy rekey * refacto: move policy and rekey action in dedicated files * chore: change vendor attribute name for covercrypt rekey action * feat: change CLI command rotate to rekey and update tests * fix: update user key locate tests * ci: fix pyo3 tests * ci: use last cloudproof python branch * refacto: master keys rekey * feat(pyo3): support and test policy attribute removal and renaming * refacto: reuse updated private key to refresh user key * ci: update cloudproof_kms_js branch * refacto: factor user keys update inner for loop in `refresh_user_decryption_key` * fix: cli rekey imports * ci: fix cargo udeps * feat: add cli command `cc keys rekey` and `cc keys prune` * feat: add cli policy edit command and tests * fix: remove deadcode and fix comments * use closures in CC keys update * fix: group KMS objects with their IDs * fix: use release test to avoid worker stack overflow upon test error * fix: review * fix: define type `KmipKeyUidObject` to store a key UID and its KmipObject * fix: apply review suggestions (cherry picked from commit ebd196e8ed251603b657e1e6445a9e6d8e75ce48) * ci: double `RUST_MIN_STACK` to `4MB` to avoid stack overflow during tests * docs: update doc of CLI rekey and policy edit * docs: update CLI doc and CHANGELOG * fix: Reduce stack footprint (#200) * CI: remove min stack size * Box in Attributes * Box key_wrapping_data and more cryptographic_parameters * Box attributes in KeyValue * Box BigUint and SafeBigUint in KeyMaterial * chore: update KMS version to `4.13.0` --------- Co-authored-by: Manuthor <manu.coste@gmail.com> Co-authored-by: Théophile BRÉZOT <theophile.brezot@cosmian.com> Co-authored-by: Thibs <ThibsG@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #193