Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix interpolation in error macros #184

Merged
merged 6 commits into from
Feb 16, 2024
Merged

Fix interpolation in error macros #184

merged 6 commits into from
Feb 16, 2024

Conversation

ThibsG
Copy link
Contributor

@ThibsG ThibsG commented Feb 15, 2024

This PR fixes string interpolation.

Before, a code like:

let var = 42;
let err = kms_error!("interpolate {var}");

was rendering

"interpolate {var}"

with this PR it is rendering

"interpolate 42"

Also, this PR fixes the Secret instantiation by turning data init from stack to heap

@ThibsG ThibsG force-pushed the fix_kmip_bail branch 7 times, most recently from 9fcb781 to c473388 Compare February 15, 2024 10:59
Base automatically changed from rework_utils_crypto to develop February 16, 2024 08:59
@ThibsG ThibsG force-pushed the fix_kmip_bail branch 2 times, most recently from c8282bf to ec3e4ce Compare February 16, 2024 09:38
@ThibsG ThibsG marked this pull request as ready for review February 16, 2024 13:24
@ThibsG ThibsG requested review from JosePisco and Manuthor February 16, 2024 13:24
Copy link
Contributor

@Manuthor Manuthor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well done!

@ThibsG ThibsG merged commit 092f831 into develop Feb 16, 2024
23 checks passed
@ThibsG ThibsG deleted the fix_kmip_bail branch February 16, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants