Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework utils/crypto #178

Merged
merged 7 commits into from
Feb 16, 2024
Merged

Rework utils/crypto #178

merged 7 commits into from
Feb 16, 2024

Conversation

ThibsG
Copy link
Contributor

@ThibsG ThibsG commented Feb 9, 2024 •
edited
Loading

  • Move crypto subcrate into kmip
  • Move KeyPair to kmip/crypto
  • Move tagging to kmip/extra
  • Move ExtraDatabaseParams into server
  • Move Access into client
  • Remove unused tee
  • Remove unused utils' feature curve25519

Fixes #174

@ThibsG ThibsG mentioned this pull request Feb 9, 2024
Closed
@JosePisco JosePisco mentioned this pull request Feb 13, 2024
Merged
@ThibsG ThibsG marked this pull request as ready for review February 14, 2024 13:40
@ThibsG ThibsG requested review from Manuthor and JosePisco February 14, 2024 13:40
JosePisco
JosePisco approved these changes Feb 14, 2024
View reviewed changes
Copy link
Contributor

@JosePisco JosePisco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clean

@JosePisco JosePisco linked an issue Feb 14, 2024 that may be closed by this pull request
Utils crate dependency on kmip #174
Closed
@JosePisco @ThibsG
feat: zeroize biguint keys (#181)
e2d6d23 
* feat: better zeroization

* feat: finalize zeroization

* revert type in kmip operation back to vec<u8>

* fix build

* revert commit reverting zeroizing + modification attempt at serializer

* Temporarily ignore rustsec from pqc-kyber

* feat: code enhancement deserialize

---------

Co-authored-by: ThibsG <thibsg@pm.me>
@Manuthor Manuthor merged commit b396f74 into develop Feb 16, 2024
23 checks passed
@Manuthor Manuthor deleted the rework_utils_crypto branch February 16, 2024 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Manuthor Manuthor Manuthor approved these changes

@JosePisco JosePisco JosePisco approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Utils crate dependency on kmip
3 participants
@ThibsG @Manuthor @JosePisco