Generalize JWKS refresh in middleware #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThibsG
force-pushed
the
generalize_jwks_refresh
branch
3 times, most recently
from
9731c03 to
ec1ce6e
Compare
ThibsG
force-pushed
the
generalize_jwks_refresh
branch
5 times, most recently
from
7cbcc2a to
b84543d
Compare
Manuthor
approved these changes
Jan 23, 2024
Manuthor
approved these changes
Jan 23, 2024
ThibsG
force-pushed
the
generalize_jwks_refresh
branch
2 times, most recently
from
53844c8 to
149a711
Compare
ThibsG
force-pushed
the
generalize_jwks_refresh
branch
from
149a711 to
59bce77
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#86 was refreshing the JWKS only in Google CSE endpoints, which was later than in the Actix middleware, where the tokens are first evaluated.
This PR proposes to fix this by moving the refreshing call in the Auth middleware when a fail occurs, and propagates the same JWKS structure to the Google CSE endpoints.
The JWKS refresh can only occur once within a time interval currently set to 1 minute.