Skip to content

Added deprecation message to check_contract. #1385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 17, 2022
Merged

Added deprecation message to check_contract. #1385

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
50d4c4f
Added deprecation message in check_contract.
jawoznia Aug 16, 2022
a81e91e
Error message in rs file and removed check_contract.sh
jawoznia Aug 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1188,7 +1188,7 @@ jobs:
command: |
echo "Checking all contracts under ./artifacts"
docker run --volumes-from with_code rust:1.59.0 \
/bin/bash -e -c 'export GLOBIGNORE="../../artifacts/floaty.wasm"; cd ./code/packages/vm; ./examples/check_contract.sh ../../artifacts/*.wasm'
/bin/bash -e -c 'export GLOBIGNORE="../../artifacts/floaty.wasm"; cd ./code/packages/vm; cargo install cw-check-contract; cw-check_contract ../../artifacts/*.wasm'
Copy link
Member

@webmaster128 webmaster128 Aug 17, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This installs an external dependency. We should use the tool from the local repository. But the cargo example directly instead of the .sh wrapper.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, yeah. I think we still need to move cw-check-contract from cw-tools to this repo and then we can use that.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jawoznia Are you okay doing that? As per #1371 (comment)

docker cp with_code:/code/artifacts .
- run:
name: Publish artifacts on GitHub
Expand Down
3 changes: 3 additions & 0 deletions packages/vm/examples/check_contract.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,9 @@ use cosmwasm_vm::internals::{check_wasm, compile};
const DEFAULT_SUPPORTED_FEATURES: &str = "iterator,staking,stargate";

pub fn main() {
eprintln!("`check_contract` will be removed from the next version of `cosmwasm-vm` - please use `cw-check-contract` instead.");
eprintln!("> cargo install cw-check-contract");

let matches = App::new("Contract checking")
.version("0.1.0")
.long_about("Checks the given wasm file (memories, exports, imports, supported features, and non-determinism).")
Expand Down
23 changes: 0 additions & 23 deletions packages/vm/examples/check_contract.sh
View file
Open in desktop

This file was deleted.