Skip to content

Added deprecation message to check_contract. #1385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 17, 2022

Conversation

jawoznia
Copy link
Contributor

No description provided.

@uint
Copy link
Contributor

uint commented Aug 16, 2022

Oh, I think we need this in check_contract.rs - we often call it directly like this:

cargo run --example check_contract ../../artifacts/hackatom.wasm

Sorry for the confusion

@uint uint self-requested a review August 16, 2022 17:01
@webmaster128
Copy link
Member

we often call it directly like this:

If we can replace this CI step with the script directly, we can get rid of the shell wrapper:

      - run:
          name: Check development contracts
          command: |
            echo "Checking all contracts under ./artifacts"
            docker run --volumes-from with_code rust:1.59.0 \
              /bin/bash -e -c 'export GLOBIGNORE="../../artifacts/floaty.wasm"; cd ./code/packages/vm; ./examples/check_contract.sh ../../artifacts/*.wasm'
            docker cp with_code:/code/artifacts .

I doubt the .sh is used anywhere outside of this repo.

Copy link
Contributor

@uint uint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@jawoznia jawoznia merged commit d83d654 into main Aug 17, 2022
@jawoznia jawoznia deleted the cw_check_contract_deprecation branch August 17, 2022 09:58
@@ -1188,7 +1188,7 @@ jobs:
command: |
echo "Checking all contracts under ./artifacts"
docker run --volumes-from with_code rust:1.59.0 \
/bin/bash -e -c 'export GLOBIGNORE="../../artifacts/floaty.wasm"; cd ./code/packages/vm; ./examples/check_contract.sh ../../artifacts/*.wasm'
/bin/bash -e -c 'export GLOBIGNORE="../../artifacts/floaty.wasm"; cd ./code/packages/vm; cargo install cw-check-contract; cw-check_contract ../../artifacts/*.wasm'
Copy link
Member

@webmaster128 webmaster128 Aug 17, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This installs an external dependency. We should use the tool from the local repository. But the cargo example directly instead of the .sh wrapper.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, yeah. I think we still need to move cw-check-contract from cw-tools to this repo and then we can use that.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jawoznia Are you okay doing that? As per #1371 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants