-
Notifications
You must be signed in to change notification settings - Fork 375
Added deprecation message to check_contract. #1385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Oh, I think we need this in cargo run --example check_contract ../../artifacts/hackatom.wasm Sorry for the confusion |
If we can replace this CI step with the script directly, we can get rid of the shell wrapper:
I doubt the .sh is used anywhere outside of this repo. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks!
@@ -1188,7 +1188,7 @@ jobs: | |||
command: | | |||
echo "Checking all contracts under ./artifacts" | |||
docker run --volumes-from with_code rust:1.59.0 \ | |||
/bin/bash -e -c 'export GLOBIGNORE="../../artifacts/floaty.wasm"; cd ./code/packages/vm; ./examples/check_contract.sh ../../artifacts/*.wasm' | |||
/bin/bash -e -c 'export GLOBIGNORE="../../artifacts/floaty.wasm"; cd ./code/packages/vm; cargo install cw-check-contract; cw-check_contract ../../artifacts/*.wasm' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This installs an external dependency. We should use the tool from the local repository. But the cargo example directly instead of the .sh wrapper.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, yeah. I think we still need to move cw-check-contract
from cw-tools
to this repo and then we can use that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jawoznia Are you okay doing that? As per #1371 (comment)
No description provided.