Update CKEditor5 to version 34.0.0 #64
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
April 28, 2022 16:06
The DocumentList plugin is able to handle more complex list entries (such as headings, tables etc.
mmichaelis
changed the title
mmichaelis
added
the
breaking
mmichaelis
approved these changes
May 19, 2022
Member
mmichaelis
left a comment
mmichaelis
left a comment
There was a problem hiding this comment.
Thanks for the update. Adjusted the PR description to provide some more details.
Added one note, that we should provide integration (contract) tests asap for the list feature to identify possible open gaps.
Comment on lines
+1343
to
+1360
| <ul> | ||
| <li><br/>Lorem Linebreak</li> | ||
| <li><span>Lorem Ipusum in additional span tag</span></li> | ||
| <li><em>Italic Lorem Ipsum in em tag</em></li> | ||
| <li><strong>Bold Lorem Ipsum in strong tag</strong></li> | ||
| <li>Lorem <sup>Ipsum</sup> (sup tag)</li> | ||
| <li>Lorem <sub>Ipsum</sub> (sub tag)</li> | ||
| <li><a xlink:href="https://example.org/">Link to example.org</a></li> | ||
| </ul> | ||
| <p>The next list contains block elements (<p>, <ol>, <blockquote>, <pre>, <table> and <img>). </p> | ||
| <ul> | ||
| <li><p>Lorem Ipsum in Paragraph</p></li> | ||
| <li><ol><li>Lorem Ipsum List Element</li></ol></li> | ||
| <li><pre>Lorem Ipsum Blocktext</pre></li> | ||
| <li><blockquote>Lorem Ipsum Blockquote</blockquote></li> | ||
| <li><table><tr><td>Lorem Ipsum Table Cell</td></tr></table></li> | ||
| <li><img xlink:href="${INLINE_IMG}" alt="inline image"/></li> | ||
| </ul> |
Member
There was a problem hiding this comment.
For manual tests, examples are enough for a first smoke-test. In the end, we should provide integration (contract) tests, also validating different combinations of attributes on various layers.
added 2 commits
May 19, 2022 16:15
# Conflicts: # app/package.json # packages/ckeditor5-common/package.json # packages/ckeditor5-coremedia-content-clipboard/package.json # packages/ckeditor5-coremedia-images/package.json # packages/ckeditor5-coremedia-link/package.json # packages/ckeditor5-coremedia-richtext-support/package.json # packages/ckeditor5-coremedia-richtext/package.json # packages/ckeditor5-coremedia-studio-essentials/package.json # packages/ckeditor5-coremedia-studio-integration-mock/package.json # packages/ckeditor5-dataprocessor-support/package.json # packages/ckeditor5-symbol-on-paste-mapper/package.json # pnpm-lock.yaml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CKEditor 5 has been updated from 32.0.0 to 34.0.0.
This corresponding related CKEditor artifacts have been updates as well:
@ckeditor/ckeditor5-dev-utilsto 30.1.3@ckeditor/ckeditor5-dev-webpack-pluginto 30.1.3@ckeditor/ckeditor5-inspectorto 4.0.0List Feature
For list feature, we changed to so-called document-lists for the example application. This is required, as CoreMedia RichText 1.0 allows also block-level elements such as paragraphs, tables, etc. in lists.
It is recommended, that you update possible usages of List to DocumentList as well, when using CKEditor 5 for editing CoreMedia RichText.
Typings Adjusted
Typings got adjusted according to the CKEditor 5 API changes. Note, that in general, it is recommended to use typings as provided at DefinitelyTyped (like ckeditor-core) until ckeditor/ckeditor5#11704 is resolved.
CKEditor 5 Migration Notes
The following migration notes are applicable: