Image Blobs Don't Render when Loaded From Data

[mmichaelis]

Describe the bug

When image blobs are referenced in data, like:

<img alt="Alternative Text: Red Image" xlink:href="content/900#properties.data"/>

They are not display anymore since CKEditor Plugins Release 5.0.0. In example data (for example "Various Images" you will see a broken image instead)

To Reproduce

Steps to reproduce the behavior:

1. Open Example Application
2. Select "Various Images" from example data.

Expected Behavior

The image is loaded from service and displayed within CKEditor.

Actual Behavior

The image is shown as a broken image with "HTML object" tag rendered on top.

Environment (please complete the following information):

• OS: iOS, Windows
• Browser: Chrome, Firefox
• CKEditor Version: 34.0.0
• CoreMedia's CKEditor Plugins Version: 5.0.0

Additional context

• Data-Processing correctly applies a dummy image (required, as blob data are retrieved lazily from backend).

• Image in Model is represented as:

  <htmlImg
    htmlAttributes="{attributes:{alt:"Alternative Text: Red Image", "data-xlink-href": "content/900#properties.data"}}"
    htmlContent="">
  </htmlImg>
  

  Thus, it is the GHS Plugin which kicks in here, and handles an unknown "img" element.

• Expectation is, that it is related to recent CKEditor Update, introduced with:

  • Update CKEditor5 to version 34.0.0 #64

[mmichaelis]

As analyzed by @JensDallmann, the issue had been caused by CKEditor Update from 32.0.0 to 34.x.

We provided a workaround for:

• image conversion (imageInline and imageBlock) does not test if src is consumed. ckeditor/ckeditor5#11327

which worked for CKEditor 32.0.0. It collided though, with recent changes due to:

• The image upcast converter does not consume the src attribute ckeditor/ckeditor5#11530

To address this issue as part of:

• Update to CKEditor 34.1.0 #67

we extended the workaround by explicitly removing the src attribute. This is part of CKEditor update to 34.1.0 branch, as we hoped that an update to 34.1.0 from 34.0.0 would have fixed the issue.