Skip to content

fix(security): restack atomic product publisher lease on 28af0b - #381

Merged
seonghobae merged 5 commits into
mainfrom
fix/atomic-product-publisher-restack-28af0b
Aug 15, 2026
Merged

fix(security): restack atomic product publisher lease on 28af0b#381
seonghobae merged 5 commits into
mainfrom
fix/atomic-product-publisher-restack-28af0b

Conversation

@seonghobae

Copy link
Copy Markdown
Contributor

Purpose

Rebuild only the unique atomic product-publisher lease delta from #378 directly on protected main 28af0b1c2e76d066a5d41ef1da56157209c89431 after #373 advanced protected truth. No predecessor CI, review, scanner, coverage, status, or model evidence transfers.

Protected main still uses a check-then-act publication sequence for the generated proposal ref and name-based cleanup. The rebuilt publisher binds branch creation and deletion to explicit Git ref leases and binds PR cleanup to a fresh server-side recovery identity before any close.

Test-first lineage

  • f4e79f4fe78d4c6f3385ed2412d45e9dcdadb127 — RED: final realistic publisher contract is installed first against protected-main behavior. It requires expected-absence ref creation, exact-head cleanup, recoverable REST PR identity, cleanup armed before create, live head/base revalidation, fully paginated post-create queue validation, and fresh recovery before closing even a previously known PR number.
  • b7167869f1e6f75a25401d61d479df9db8e9e3b8 — GREEN current exact head: applies the reviewed atomic publisher implementation and a current-lineage doctoring record.

Fresh comparison against protected main is exactly two commits ahead, zero behind, changing only:

  • .github/workflows/hourly-product-development.yml
  • test/hourly-product-development-publisher-lease.test.ts
  • docs/doctoring/atomic-product-publisher-lease.md

The current-lineage implementation includes the valid #378 review correction: cleanup discards any previously returned numeric PR identifier, reruns marker + exact proposal-head + expected-base recovery, and closes only the single recovered matching PR. The predecessor thread is resolved, but its review state is not promoted to this new head.

Authority boundary

The NVIDIA credential-bearing proposer remains shell-denied; executable proposal verification remains separate and uncredentialed; the credential-bearing publisher remains non-executing. This change grants no review, merge, release, deployment, licensing, KPI, customer, revenue, or acquisition authority.

Do not merge until unchanged exact head b7167869f1e6f75a25401d61d479df9db8e9e3b8 has fresh terminal-success application ci, reviewer-ci, eligible protected-base central Security Scan, exact configured 100% owned-production statement/branch/function/line coverage, applicable package/SBOM/provenance gates, and zero valid unresolved findings. Pending, queued, skipped, absent, neutral, failed, cancelled, stale, predecessor, status-only, model-only, or rate-limited evidence is non-passing.

No force push, destructive rebase, self-approval, gate weakening, reviewer/secret invention, repair/self-modifying workflow, release, deployment, or outbound-license decision is introduced.

Related: #80, #96, #227. Supersedes #378 for this bounded publisher slice.

@coderabbitai

coderabbitai Bot commented Aug 15, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@seonghobae, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 2 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: aafa4c98-4138-442b-a702-fdcb6af85247

📥 Commits

Reviewing files that changed from the base of the PR and between ac4c311 and 25e8513.

📒 Files selected for processing (4)
  • .github/workflows/hourly-product-development.yml
  • docs/doctoring/atomic-product-publisher-lease.md
  • test/hourly-product-development-publisher-lease.test.ts
  • test/hourly-product-development-workflow.test.ts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copy link
Copy Markdown
Contributor Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Aug 15, 2026

Copy link
Copy Markdown
⚠️ Action not completed

Review rate limited.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@seonghobae
seonghobae merged commit 40dfe2c into main Aug 15, 2026
16 checks passed
@seonghobae
seonghobae deleted the fix/atomic-product-publisher-restack-28af0b branch August 15, 2026 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant