Skip to content

fix(security): restack scheduler descriptor drift detection - #373

Merged
seonghobae merged 3 commits into
mainfrom
fix/external-scheduler-descriptor-restack-2db716
Aug 15, 2026
Merged

fix(security): restack scheduler descriptor drift detection#373
seonghobae merged 3 commits into
mainfrom
fix/external-scheduler-descriptor-restack-2db716

Conversation

@seonghobae

Copy link
Copy Markdown
Contributor

Purpose

Rebuild only the unique external-scheduler descriptor-stability delta from #372 directly on current protected main 2db716d7252603689b2cc18b700bac25e872b28f after #366 advanced the protected lineage. No predecessor check, review, scanner, or coverage evidence transfers.

The retained external scheduler evidence reader already opens a bounded regular file with O_NOFOLLOW and validates exact byte length. It now obtains descriptor metadata again after reading and fails closed if regular-file status, device, inode, size, modification time, or status-change time drifted while bytes were consumed.

Test-first lineage

  • a0b03408fbbdb0184f4fba50f4871df5a612b64c — RED regression: post-read non-file/device/inode/size/mtime/ctime drift must be rejected and the descriptor must still close.
  • 6b8c110655945b7301fa5d7337587fc12e727625 — GREEN implementation: second fstatSync binds accepted bytes to an unchanged descriptor snapshot.
  • 637162d89a33a521d03c0d3c3869bb36f094c32a — current exact head; records POSIX.1-2024, Node filesystem, and NIST SSDF doctoring.

Current-base identity

Fresh compare against protected main is exactly three commits ahead, zero behind, with only:

  • scripts/external-scheduler-evidence-audit.mjs
  • test/external-scheduler-evidence-post-read-stability.test.ts
  • docs/doctoring/external-scheduler-descriptor-stability.md

This is the clean current-main successor to stale #372. The old branch is not merge authority and its evidence is historical only.

Evidence boundary

This control detects bounded local descriptor mutation; it does not prove provider scheduler identity, enablement, production execution, host privilege isolation, release/deployment acceptance, or acquisition readiness. Higher-authority storage mutation and filesystem timestamp granularity remain explicit limits.

Do not merge until unchanged exact head 637162d89a33a521d03c0d3c3869bb36f094c32a has fresh terminal-success application ci, reviewer-ci, eligible protected-base central Security Scan, exact configured 100% owned-production statement/branch/function/line coverage, and zero valid unresolved findings. Pending, queued, skipped, absent, neutral, failed, cancelled, stale, predecessor, status-only, model-only, or rate-limited evidence is non-passing.

No force update, self-approval, gate weakening, reviewer/secret invention, repair/self-modifying workflow, outbound-license decision, release, deployment, or fabricated production evidence is introduced.

Related: #96. Supersedes #372.

@coderabbitai

coderabbitai Bot commented Aug 15, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@seonghobae, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 34 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 3d5e1419-d2d3-452f-8c97-a6c43f031569

📥 Commits

Reviewing files that changed from the base of the PR and between 2db716d and 637162d.

📒 Files selected for processing (3)
  • docs/doctoring/external-scheduler-descriptor-stability.md
  • scripts/external-scheduler-evidence-audit.mjs
  • test/external-scheduler-evidence-post-read-stability.test.ts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant