feat(workspace): name the first entrance time on lock-in pairs by seonghobae · Pull Request #888 · ContextualWisdomLab/bandscope

seonghobae · 2026-08-16T16:42:49Z

Summary

Players can now see when to lock in, not only which part. The Rehearsal Priorities card names the first entrance time on each lock-in pair and focus label, marks the activated pair as current, keeps role names from rewriting later aria-label tokens, and skips smooth roadmap scrolling when the player prefers reduced motion.

Supersession / canonical owner evidence

This work has been consolidated into the older canonical owner #874 rather than leaving two same-scope PRs open.

Immediately before consolidation:

feat(workspace): name the parts to lock in first #874 exact head was 43cb9438d6338890a218f2d3b7c4ba74199adb00;
feat(workspace): name the first entrance time on lock-in pairs #888 exact head was 05935e02f29366b2bd240d6fb4d1bae784cb992b;
exact GitHub compare reported status=ahead, ahead_by=2, behind_by=0, with merge-base exactly 43cb9438....

The #874 branch was then fast-forwarded non-forced to 05935e02f29366b2bd240d6fb4d1bae784cb992b. Fresh PR refetch confirms #874 and #888 now reference that identical exact head. Therefore every #888 source/test/doc commit is preserved on #874, and this PR is closed as superseded without semantic loss.

No #888 check, review, or approval transfers to #874 merely because the code identity is now equal; #874 must generate/revalidate its own required PR-context evidence and qualifying independent last-push approval.

Security boundary

Presentation-only. Already-validated RehearsalSong role names, section labels, focus strings, and section.timeRange.start values remain React text/control data. No dependency, lockfile, file, URL, subprocess, IPC, WebView, model, database, persistence, or new authority boundary is introduced.

Test points retained on #874

entrance-time labels such as 0:10 / 0:30;
activated pair exposes aria-current="true";
role text containing {sectionLabel} cannot recursively rewrite a later aria-label token;
reduced-motion preference uses non-smooth roadmap movement;
all predecessor role/focus deduplication and no-op prevention behavior remains.

Keep #874 Draft until its own exact-head repository/central CI, exact coverage, security/SBOM/supply-chain/release, unresolved-thread, and independent non-author last-push approval gates pass.

Replace the stub rehearsal-priorities card with role-and-section pairs so a player can see what to lock in before the room starts. Prefer high priority, then medium, then focus sections, and never turn blank or none sentinels into instructions. Co-authored-by: Seongho Bae <seonghobae@users.noreply.github.com>

Repeated verse labels no longer consume the third rehearsal-priority slot, and empty copy now points at the section roadmap instead of a no-op role click. Co-authored-by: Seongho Bae <seonghobae@users.noreply.github.com>

Clicking a named role-and-section pair selects that role and focuses the matching section so players can jump from the priority card into the part they need to lock. Co-authored-by: Seongho Bae <seonghobae@users.noreply.github.com>

Fallback focus labels now jump to the first matching section so players can still act when analysis only names a section, not a role pair. Co-authored-by: Seongho Bae <seonghobae@users.noreply.github.com>

Omit focus labels that do not match a roadmap card so a missing bridge cannot clear verse focus. Scroll the named section into view when a lock-in pair or fallback label is opened. Co-authored-by: Seongho Bae <seonghobae@users.noreply.github.com>

Show when each lock-in part starts, mark the activated pair as current, keep aria-label tokens from rewriting each other, and skip smooth roadmap scrolling when the player prefers reduced motion. Co-authored-by: Seongho Bae <seonghobae@users.noreply.github.com>

coderabbitai · 2026-08-16T16:43:04Z

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: fcdb8088-81d5-4d86-8b09-4a8fc1822bd3

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

A lock-in click now marks the same section on the song-structure timeline so players can see the entrance on both the form strip and the roadmap. Co-authored-by: Seongho Bae <seonghobae@users.noreply.github.com>

cursor

Stale comment

Review (05935e02 vs develop@acdbea63)

Draft lock-in landing. Prefer this over #874 (43cb9438) and closed #880/#882. Do not merge those in parallel. Do not mix Stem Lab (#884) or NIM (#881) onto this slice.

Players can see when to lock in, not only which part. High-priority pairs stay first, unmatched focus labels are omitted so the card cannot sell a no-op, and the song-structure tile for the activated section is marked data-focused-section.

CodeRabbit CLI agent auth timed out here. This is a CodeRabbit-style review of the fetched head, not a CodeRabbit service run.

Critical: 0. Warning: 0. Info: 1.

Entrance time is the section window start (inline). That matches "open this section now." It is not a stem-onset timestamp.

Do not merge while draft. Do not merge until exact-head CI is green and a qualifying independent non-author last-push approval exists. Do not self-approve.

_{Sent by Cursor Automation: Fix Issues}

cursor · 2026-08-16T16:45:53Z

+          sectionId: section.id,
+          roleName,
+          sectionLabel,
+          sectionStartSeconds: section.timeRange.start


Info: sectionStartSeconds is the section window start, not a measured role onset. That is the right lock-in cue when the pair means "this part in this section." Keep copy and tests saying section entrance so a later pickup/dropout lane cannot silently reuse this as note-onset evidence. Not merge-blocking.

cursor

Review — lock-in first entrance times (`05935e02`)

This Draft is the lock-in-first landing over #874. The written slice holds: named role/section pairs, first entrance from section.timeRange.start, honest empty copy, unmatched bridge omitted, one-pass {token} interpolation, aria-current on the activated pair, reduced-motion roadmap scroll, and the same section marked on the song-structure timeline.

Local verification: Workspace.test.tsx, SectionRoadmap.test.tsx, Workspace.priority-focus-dedup.test.tsx, and i18n/index.test.ts — 46 passed at this head. GitHub Checks were still queued/in progress on 05935e02; that is not a code blocker.

Buyer next action: Keep this Draft as the lock-in vehicle. Do not merge #874 in parallel. After required checks on this exact SHA, mark Ready so CodeRabbit can run (it skipped because this is a Draft). Do not mix #884 Stem Lab or #890 real-audio accuracy onto this branch.

Residual (not a slice blocker): the song-structure timeline paints data-focused-section but does not scrollIntoView. On a narrow cockpit or a longer form, chorus can be highlighted off-screen. The roadmap is the one destination that actually moves. Role-level entrance times are also out of scope until RehearsalRole grows an entrance field.

Merge posture: COMMENT only. Author is seonghobae. This automation does not approve or merge. Independent non-author review plus current-head required checks still have to land.

_{Sent by Cursor Automation: Fix Issues}

cursor · 2026-08-16T16:50:48Z

+            <div
+              key={section.id}
+              data-testid={`song-structure-${section.id}`}
+              data-focused-section={section.id === focusedSectionId ? "true" : undefined}


This cell gets data-focused-section and a ring, but SongStructure never calls scrollIntoView. The wrapping region is overflow-x-auto with min-w-[720px], so a lock-in click to chorus can highlight a cell the player cannot see.

SectionRoadmap already scrolls with reduced-motion auto. Mirror that here if this card is meant to be the second visible destination. Until then, CHANGELOG’s “one visible destination” is true for the roadmap only. Not a merge blocker for the written plan.

cursoragent and others added 9 commits August 16, 2026 15:25

test(workspace): dedupe fallback focus sections before rendering

65ec4d4

fix(workspace): dedupe normalized fallback focus sections

50cc1d9

docs(changelog): record deduplicated priority fallback

5cd1afd

fix(workspace): keep lock-in pairs display-unique and honest

df02305

Repeated verse labels no longer consume the third rehearsal-priority slot, and empty copy now points at the section roadmap instead of a no-op role click. Co-authored-by: Seongho Bae <seonghobae@users.noreply.github.com>

feat(workspace): open a lock-in pair on the roadmap

5fa854a

Clicking a named role-and-section pair selects that role and focuses the matching section so players can jump from the priority card into the part they need to lock. Co-authored-by: Seongho Bae <seonghobae@users.noreply.github.com>

feat(workspace): open a focus-section label on the roadmap

c646037

Fallback focus labels now jump to the first matching section so players can still act when analysis only names a section, not a role pair. Co-authored-by: Seongho Bae <seonghobae@users.noreply.github.com>

cursor Bot mentioned this pull request Aug 16, 2026

feat(workspace): name the parts to lock in first #874

Draft

feat(workspace): highlight the focused section on the song timeline

05935e0

A lock-in click now marks the same section on the song-structure timeline so players can see the entrance on both the form strip and the roadmap. Co-authored-by: Seongho Bae <seonghobae@users.noreply.github.com>

cursor Bot reviewed Aug 16, 2026

View reviewed changes

This was referenced Aug 16, 2026

test(analysis): add Tier 1 real-audio accuracy acceptance #890

Closed

test(analysis): lock verse/chorus chord recovery on a known take #891

Draft

fix(analysis): score C major acceptance from decoded WAV bytes #892

Draft

seonghobae closed this Aug 16, 2026

Navigation Menu

Uh oh!

feat(workspace): name the first entrance time on lock-in pairs - #888

feat(workspace): name the first entrance time on lock-in pairs#888
seonghobae wants to merge 10 commits into
developfrom
cursor/bc-bdda22bb-869b-4079-b4d9-ed08f1131b25-1326

seonghobae commented Aug 16, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot commented Aug 16, 2026 •

edited

Loading

Review skipped

Uh oh!

cursor Bot left a comment •

edited

Loading

Uh oh!

cursor Bot Aug 16, 2026

Uh oh!

cursor Bot left a comment

Uh oh!

cursor Bot Aug 16, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

seonghobae commented Aug 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Supersession / canonical owner evidence

Security boundary

Test points retained on #874

Uh oh!

coderabbitai Bot commented Aug 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

cursor Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Review (05935e02 vs develop@acdbea63)

Uh oh!

cursor Bot Aug 16, 2026

Choose a reason for hiding this comment

Uh oh!

cursor Bot left a comment

Choose a reason for hiding this comment

Review — lock-in first entrance times (05935e02)

Uh oh!

cursor Bot Aug 16, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

seonghobae commented Aug 16, 2026 •

edited

Loading

coderabbitai Bot commented Aug 16, 2026 •

edited

Loading

cursor Bot left a comment •

edited

Loading

Review (`05935e02` vs `develop@acdbea63`)

Review — lock-in first entrance times (`05935e02`)