Skip to content

fix(workspace): keep unmatched focus labels from selling a no-op - #882

Closed
cursor[bot] wants to merge 8 commits into
developfrom
cursor/bc-0eb55682-a5ed-47cb-b74f-7e552f6c57a4-a93b
Closed

fix(workspace): keep unmatched focus labels from selling a no-op#882
cursor[bot] wants to merge 8 commits into
developfrom
cursor/bc-0eb55682-a5ed-47cb-b74f-7e552f6c57a4-a93b

Conversation

@cursor

@cursor cursor Bot commented Aug 16, 2026

Copy link
Copy Markdown

Closed as proven duplicate of canonical #874

Exact evidence before closure:

No predecessor or duplicate PR checks/reviews transfer. #874 must regenerate exact-current-head CI/coverage/security/SBOM/supply-chain/review evidence on 43cb9438… and remain gated by #783/#861/central prerequisites plus independent approval.

cursoragent and others added 8 commits August 16, 2026 15:25
Replace the stub rehearsal-priorities card with role-and-section pairs
so a player can see what to lock in before the room starts. Prefer high
priority, then medium, then focus sections, and never turn blank or none
sentinels into instructions.

Co-authored-by: Seongho Bae <seonghobae@users.noreply.github.com>
Repeated verse labels no longer consume the third rehearsal-priority slot, and empty copy now points at the section roadmap instead of a no-op role click.

Co-authored-by: Seongho Bae <seonghobae@users.noreply.github.com>
Clicking a named role-and-section pair selects that role and focuses the matching section so players can jump from the priority card into the part they need to lock.

Co-authored-by: Seongho Bae <seonghobae@users.noreply.github.com>
Fallback focus labels now jump to the first matching section so players can still act when analysis only names a section, not a role pair.

Co-authored-by: Seongho Bae <seonghobae@users.noreply.github.com>
Omit focus labels that do not match a roadmap card so a missing
bridge cannot clear verse focus. Scroll the named section into
view when a lock-in pair or fallback label is opened.

Co-authored-by: Seongho Bae <seonghobae@users.noreply.github.com>

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stale comment

Review at 43cb9438

This draft is the same tree as #880 a0c2e612 (1e75a423). #880 is already on develop and ready for review.

Do not merge #882. Landing vehicle is #880. Keep this draft closed or idle so the residual-fix slice has one PR.

The unmatched-label omit, none first-section walk, and roadmap scrollIntoView / aria-current behavior is sound. Distinct from #776. Do not mix stem-lane work onto this slice.

View PR

Open in Web View Automation 

Sent by Cursor Automation: Fix Issues

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Defer to #880

#880 is now retargeted to develop@acdbea63 at a0c2e612. That is the lock-in landing vehicle.

This draft (43cb9438) is the same residual opened while #880 still showed main. Keep it draft and unmerged. Do not land it in parallel with #880 or #874. Do not open a third residual-fix PR. Do not mix stem-lane work here.

This comment is not approval.

Open in Web View Automation 

Sent by Cursor Automation: Fix Issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants