Fixup 87237fa61a3982f41a12742f5ad15e7a6dc0efc5 #704
Conversation
|
The integration tests are still failing, though. |
|
|
||
| def static String MODULEROOT = Paths.get("").toAbsolutePath().getParent().toString() | ||
| def static String TAPEROOT = "/" + MODULEROOT + "src/test/resources/tapes/" | ||
| def static String TAPEROOT = MODULEROOT + "/" + "src/test/resources/tapes/" |
There was a problem hiding this comment.
@olivergondza I think it should be
TAPEROOT = "/" + MODULEROOT + "/src/test/resources/tapes/"
With JDK 1.7 that reduces the amount of errors in the integration-test module to 3 NPE's caused by UnknownHostExceptions. Very strange. I'm currently looking into it.
There was a problem hiding this comment.
That is strange, the absolute path should start with '/' so additional
should be ignored and it will blow up on Windows completely. Can we
agree on MODULEROOT + "/src/test/resources/tapes/"?
On 06/02/2016 02:53 PM, Arno Uhlig wrote:
In
core-integration-test/src/test/groovy/org/openstack4j/api/AbstractSpec.groovy
#704 (comment):@@ -18,7 +18,7 @@ import co.freeside.betamax.tape.yaml.TapePropertyUtils
abstract class AbstractSpec extends Specification {def static String MODULEROOT = Paths.get("").toAbsolutePath().getParent().toString()
- def static String TAPEROOT = "/" + MODULEROOT + "src/test/resources/tapes/"
- def static String TAPEROOT = MODULEROOT + "/" + "src/test/resources/tapes/"
@olivergondza https://github.com/olivergondza I think it should be
TAPEROOT = "/" + MODULEROOT + "/src/test/resources/tapes/"With JDK 1.7 that reduces the amount of errors in the integration-test
module to 3 NPE's caused by UnknownHostExceptions. Very strange. I'm
currently looking into it.—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/ContainX/openstack4j/pull/704/files/f5fa1dc540f634c819f3ff030be09fe6df3bea7a#r65533145,
or mute the thread
https://github.com/notifications/unsubscribe/AAMn-cJv-jnn3Dinr4_3njNQHIoAd0Woks5qHtJfgaJpZM4Ir3Cq.
There was a problem hiding this comment.
Yes, makes sense.
The remaining 3 issues, which prevent os4j from going back to green, are still unclear to me.
Maybe it's something in Betamax. Need to dig in this again tomorrow - unless you're faster.
|
Rebased, with what we agreed on. This is ready to be merged. |
2 participants
This fixes a mistake made in #693.