Skip to content

Conversation

@olivergondza
Copy link
Collaborator

  • Project depends on 1.7
  • Controllers affected by JDK-7157360 depends on 1.8
  • distribution module depends on openstack4j-resteasy

@olivergondza
Copy link
Collaborator Author

I managed to get the build to pass on JDK 7 using mvn clean install -pl '!org.pacesys.openstack4j.connectors:openstack4j-http-connector,!org.pacesys.openstack4j.connectors:openstack4j-jersey2,!org.pacesys:it-jersey2' (skipping affected controllers). Except for integration tests that does not work for me with Java 8 either.

@olivergondza olivergondza mentioned this pull request May 30, 2016
@gondor
Copy link
Member

gondor commented May 30, 2016

@auhlig and @dhague can you review this

@dhague
Copy link
Collaborator

dhague commented Jun 1, 2016

LGTM - nice work!

@dhague dhague merged commit 2a0b6de into ContainX:master Jun 1, 2016
@gondor
Copy link
Member

gondor commented Jun 1, 2016

@dhague @olivergondza @auhlig

for some reason Travis which runs "mvn test -B" passes but trying to deploy which goes through "mvn verify" fails. I was trying to cut a release this morning. Can someone find out why some groovy tests are failing using "mvn verify" ? If not we'll have to revert this change.

Common error seen:

Running org.openstack4j.api.identity.v3.KeystoneProjectServiceSpec
Jun 01, 2016 7:05:48 AM org.codehaus.groovy.runtime.callsite.PojoMetaMethodSite$PojoCachedMethodSiteNoUnwrap invoke
INFO: local address is loopback, using hostname C02Q41AMG8WM-M.local
Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.121 sec <<< FAILURE! - in org.openstack4j.api.identity.v3.KeystoneProjectServiceSpec
create, read, update, delete project service test cases(org.openstack4j.api.identity.v3.KeystoneProjectServiceSpec)  Time elapsed: 0.12 sec  <<< ERROR!
java.lang.AbstractMethodError: javax.ws.rs.core.UriBuilder.uri(Ljava/lang/String;)Ljavax/ws/rs/core/UriBuilder;
    at org.openstack4j.api.identity.v3.KeystoneProjectServiceSpec.create, read, update, delete project service test cases(KeystoneProjectServiceSpec.groovy:77)

@auhlig
Copy link
Member

auhlig commented Jun 1, 2016

I guess mvn test runs only the unit tests. But the integration-tests are only executed in the integration-phase which is a previous phase of verify.

@gondor
Copy link
Member

gondor commented Jun 1, 2016

Ok, gonna update travis to always test using "mvn verify"

@auhlig
Copy link
Member

auhlig commented Jun 1, 2016

Yes. Sorry. Should have thought of that before.

@auhlig auhlig mentioned this pull request Jun 3, 2016
@gondor gondor added this to the 3.0.1 Release milestone Jun 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants