Repository navigation
fix: propagate validation and generation failures - #79
Open
ryanduguid wants to merge 2 commits into
Open
ryanduguid wants to merge 2 commits into
ryanduguid wants to merge 2 commits into
Conversation
Drop the TSLint dependency and configuration so this change covers only the validation and generation exit codes.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Valid documents currently make the validation CLI exit 1, while JSON and schema failures exit 0. The root validation and generation scripts also lose a first worker's failure because they run it in the background.
Return 0 for successful validation and 1 for failure. Run the paired workers sequentially with
&&so either failure propagates. Remove the build step that copies a nonexistent, unusedconfig.json, and add regression checks using the real compiler, schema engine and generators with fabricated files.Verification at
62b51a0on Windows with Node 24.19.0 and Git Bash:npm ci --ignore-scripts --no-audit --no-fundandnpm testinclipass. All 16 regression checks pass, covering both validation modes, malformed and missing files, invalid schemas and each aggregate worker's failure.npm run lintcannot run: the unchanged script invokes TSLint, which is not a declared dependency. This PR does not add a linter or lint policy.git diff --checkpasses.The runtime dependencies and schema definitions are unchanged. No package was published. Linux, older Node versions and hosted CI have not been verified in this review. The schema-output fix remains in #78.