Repository navigation
fix: emit only the requested JSON schema - #78
Open
ryanduguid wants to merge 2 commits into
Open
ryanduguid wants to merge 2 commits into
ryanduguid wants to merge 2 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
testdocs schema testdoccurrently writes a text label followed by both schemas.testdocs schema changelogalso prepends a label. Both exit successfully, but their output cannot be parsed as JSON.Remove the label and stop the testdoc switch case from falling through. Set
process.exitCodeinstead of forcing an immediate exit, so asynchronous stdout writes can finish. Each command emits only the requested JSON schema. Node documents the output-loss risk of immediate exit in its process documentation.Verification at
fd396econ Windows with Node 24.19.0:node test/schema-output.js: all 8 checks pass. These cover ordinary pipes, files, delayed stdout writes and missing or invalid arguments. Both delayed-write cases fail on the previous PR head with empty output. The delayed stream models asynchronous writes; it is not a Linux execution test.git diff --checkpass.npm run buildcompiles successfully, then fails at the unchangedcopy-additionalstep becausecli/config.jsonis absent. PR fix: propagate validation and generation failures #79 removes that unused step.No dependencies or schema definitions changed. Linux execution and full documentation generation were not verified. This branch is independent of #77.