-
Notifications
You must be signed in to change notification settings - Fork 2
[CI-3307] useProductInfo hook tests #72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
stanlp1
merged 3 commits into
main
from
ci-3307-mvp-os-ui-plp-add-tests-for-useproductcard-hook
May 6, 2024
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -19,6 +19,7 @@ | |
| "Favorited", | ||
| "favorited", | ||
| "dtype", | ||
| "cnstrc" | ||
| "cnstrc", | ||
| "Catchify", | ||
| ] | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,111 @@ | ||
| import '@testing-library/jest-dom'; | ||
| import { renderHook, waitFor } from '@testing-library/react'; | ||
| import useProductInfo from '../src/hooks/useProduct'; | ||
| import { transformResultItem } from '../src/utils/transformers'; | ||
| import mockItem from './local_examples/item.json'; | ||
| import { renderHookWithCioPlp } from './test-utils'; | ||
|
|
||
| describe('Testing Hook: useProductInfo', () => { | ||
| beforeEach(() => { | ||
| // Mock console error to de-clutter the console for expected errors | ||
| const spy = jest.spyOn(console, 'error'); | ||
| spy.mockImplementation(() => {}); | ||
| }); | ||
|
|
||
| afterEach(() => { | ||
| jest.restoreAllMocks(); // This will reset all mocks after each test | ||
| }); | ||
|
|
||
| it('Should throw error if called outside of PlpContext', () => { | ||
| expect(() => renderHook(() => useProductInfo())).toThrow(); | ||
| }); | ||
|
|
||
| const transformedItem = transformResultItem(mockItem); | ||
|
|
||
| it('Should return productSwatch, itemName, itemImageUrl, itemUrl, itemPrice', async () => { | ||
| const { result } = renderHookWithCioPlp(() => useProductInfo({ item: transformedItem })); | ||
|
|
||
| await waitFor(() => { | ||
| const { | ||
| current: { productSwatch, itemName, itemImageUrl, itemUrl, itemPrice }, | ||
| } = result; | ||
|
|
||
| expect(productSwatch).not.toBeNull(); | ||
| expect(itemName).toEqual(transformedItem.itemName); | ||
| expect(itemImageUrl).toEqual(transformedItem.imageUrl); | ||
| expect(itemUrl).toEqual(transformedItem.url); | ||
| expect(itemPrice).toEqual(transformedItem.data.price); | ||
| }); | ||
| }); | ||
|
|
||
| it('Should return nothing properly with getters that return nothing', async () => { | ||
| const { result } = renderHookWithCioPlp(() => useProductInfo({ item: transformedItem }), { | ||
| initialProps: { | ||
| itemFieldGetters: { | ||
| getPrice: () => {}, | ||
| getSwatches: () => {}, | ||
| getSwatchPreview: () => {}, | ||
| }, | ||
| }, | ||
| }); | ||
|
|
||
| await waitFor(() => { | ||
| const { | ||
| current: { productSwatch, itemName, itemImageUrl, itemUrl, itemPrice }, | ||
| } = result; | ||
|
|
||
| expect(productSwatch).not.toBeNull(); | ||
| expect(itemName).toEqual(transformedItem.itemName); | ||
| expect(itemImageUrl).toEqual(transformedItem.imageUrl); | ||
| expect(itemUrl).toEqual(transformedItem.url); | ||
| expect(itemPrice).toBeUndefined(); | ||
| }); | ||
| }); | ||
|
|
||
| it('Should return correctly after different variation is selected', async () => { | ||
| const { result } = renderHookWithCioPlp(() => useProductInfo({ item: transformedItem })); | ||
|
|
||
| await waitFor(() => { | ||
| const { | ||
| current: { productSwatch, itemName, itemImageUrl, itemUrl, itemPrice }, | ||
| } = result; | ||
| const { selectVariation, swatchList } = productSwatch; | ||
| selectVariation(swatchList[1]); | ||
|
|
||
| expect(itemName).toEqual(swatchList[1].itemName); | ||
| expect(itemImageUrl).toEqual(swatchList[1].imageUrl || transformedItem.imageUrl); | ||
| expect(itemUrl).toEqual(swatchList[1].url || transformedItem.url); | ||
| expect(itemPrice).toEqual(swatchList[1].price || transformedItem.data.price); | ||
| }); | ||
| }); | ||
|
|
||
| it('Should return nothing properly with getters that throw errors', async () => { | ||
| const { result } = renderHookWithCioPlp(() => useProductInfo({ item: transformedItem }), { | ||
| initialProps: { | ||
| itemFieldGetters: { | ||
| getPrice: () => { | ||
| throw new Error(); | ||
| }, | ||
| getSwatches: () => { | ||
| throw new Error(); | ||
| }, | ||
| getSwatchPreview: () => { | ||
| throw new Error(); | ||
| }, | ||
| }, | ||
| }, | ||
| }); | ||
|
|
||
| await waitFor(() => { | ||
| const { | ||
| current: { productSwatch, itemName, itemImageUrl, itemUrl, itemPrice }, | ||
| } = result; | ||
|
|
||
| expect(productSwatch).not.toBeNull(); | ||
| expect(itemName).toEqual(transformedItem.itemName); | ||
| expect(itemImageUrl).toEqual(transformedItem.imageUrl); | ||
| expect(itemUrl).toEqual(transformedItem.url); | ||
| expect(itemPrice).toBeUndefined(); | ||
| }); | ||
| }); | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤔 I don't know what we should be doing here other than try catching it.
I was thinking of doing this to everything in itemFieldGetters.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cspeller still complaining. Lets add the word Catchify to the list of cspeller words