[CI-3307] useProductInfo hook tests #72
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CI-3307 [MVP - OS UI PLP] - Add tests for useProductCard hook
Business Outcome:
Definition of done:
|
stanlp1
commented
Apr 25, 2024
| } | ||
|
|
||
| const getPrice = state?.itemFieldGetters?.getPrice; | ||
| const getPrice = tryCatchify(state?.itemFieldGetters?.getPrice); |
Contributor
Author
There was a problem hiding this comment.
🤔 I don't know what we should be doing here other than try catching it.
I was thinking of doing this to everything in itemFieldGetters.
Contributor
There was a problem hiding this comment.
cspeller still complaining. Lets add the word Catchify to the list of cspeller words
esezen
reviewed
May 1, 2024
src/utils.tsx
Outdated
| try { | ||
| return func(...args); | ||
| } catch (e) { | ||
| // do nothing |
Contributor
There was a problem hiding this comment.
Can we add something like the logger and have call it here? It would only console log in dev mode. That way we can let the user know there is a problem with the implementation during development but don't break anything in prod if the value is missing
stanlp1
deleted the
ci-3307-mvp-os-ui-plp-add-tests-for-useproductcard-hook
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Before you submit a pull request, please make sure you have to following:
PR Type
What kind of change does this PR introduce?