Skip to content

[CI-4329] Update filters list to be ul #145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[CI-4329] Update filters list to be ul #145

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e28564e
update filters list to be ul
stanlp1 Apr 10, 2025
187726c
remove margin
stanlp1 Apr 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/components/Filters/Filters.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ export default function Filters(props: FiltersWithRenderProps) {
setFilter,
})
) : (
<div className='cio-filters'>
<ul className='cio-filters'>
{facets.map((facet) => (
<FilterGroup
facet={facet}
Expand All @@ -34,7 +34,7 @@ export default function Filters(props: FiltersWithRenderProps) {
key={facet.name}
/>
))}
</div>
</ul>
)}
</>
);
Expand Down
3 changes: 3 additions & 0 deletions src/components/Filters/index.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,9 @@
display: flex;
flex-direction: column;
row-gap: 24px;
list-style-type: none;
padding: 0;
margin: 0;
}

.cio-filter-group {
Expand Down
Loading