Skip to content

[CI-4329] Update filters list to be ul #145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[CI-4329] Update filters list to be ul #145

wants to merge 2 commits into from

Conversation

@stanlp1
Copy link
Contributor

@stanlp1 stanlp1 commented Apr 10, 2025 •
edited
Loading

Pull Request Checklist

Before you submit a pull request, please make sure you have to following:

  • I have added or updated TypeScript types for my changes, ensuring they are compatible with the existing codebase.
  • I have added JSDoc comments to my TypeScript definitions for improved documentation.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added any necessary documentation (if appropriate).
  • I have made sure my PR is up-to-date with the main branch.

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no API changes)
  • Documentation content changes
  • TypeScript type definitions update
  • Other... Please describe:

@stanlp1 stanlp1 requested a review from a team as a code owner April 10, 2025 06:31
mocca102
mocca102 requested changes Apr 11, 2025
View reviewed changes
Copy link
Contributor

@mocca102 mocca102 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is me nitpicking but there's top marign that got added.

Screenshot 2025-04-11 at 3 57 04 PM

@stanlp1 stanlp1 requested a review from mocca102 April 11, 2025 16:11
@Mudaafi Mudaafi added the do not merge Do not merge label Apr 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lordvkrum lordvkrum lordvkrum approved these changes

@mocca102 mocca102 Awaiting requested review from mocca102

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

do not merge Do not merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@stanlp1 @lordvkrum @mocca102 @Mudaafi