news section with carousel component #110
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KHVBui
previously requested changes
Nov 2, 2022
There was a problem hiding this comment.
Homepage and App should be jsx files. You might want to also pull changes from main since it looks like this branch is behind several PR's.
There are a lot of ESLint and Prettier errors you need to correct. If you have those plugins installed correctly, the errors should show after running npm run build.
Most of the errors center around prop validation, so you can just look at some of the event component files for examples.
DanielZavala11
force-pushed
the
news-cs-branch
branch
from
34a9d87 to
c04e960
Compare
…anged proptypes; adjusted inner-carousel and card sliding
|
Reject PR for cleaning up the repo. Changes in under directory
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue #53