Skip to content

Conversation

AlexXuan233
Copy link
Contributor

We do not use Jinja2 in control files, profile files and var files

Description:

Remove useless jinja2 doc.

Rationale:

We do not use Jinja2 in control files, profile files and var files

Review Hints:

Related PR:
#13584
#13573
#13585

@Mab879 Mab879 self-assigned this Jun 18, 2025
@marcusburghardt marcusburghardt added this to the 0.1.78 milestone Jun 20, 2025
We do not use Jinja2 in control files, profile files and var files
@AlexXuan233
Copy link
Contributor Author

@jan-cerny @marcusburghardt Updated. Thanks guys.

Copy link
Member

@marcusburghardt marcusburghardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@marcusburghardt marcusburghardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RichardXuan , I suggested an update to incorporate the feedback discussed here: #13592 (comment)

@marcusburghardt
Copy link
Member

@RichardXuan , I suggested an update to incorporate the feedback discussed here: #13592 (comment)

FYI @teacup-on-rockingchair

Co-authored-by: Marcus Burghardt <2074099+marcusburghardt@users.noreply.github.com>
@AlexXuan233
Copy link
Contributor Author

@RichardXuan , I suggested an update to incorporate the feedback discussed here: #13592 (comment)

@marcusburghardt Updated. Thanks your suggestion. cc @teacup-on-rockingchair

Copy link

Code Climate has analyzed commit 11df9ff and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 61.9% (0.0% change).

View more on Code Climate.

Copy link
Member

@marcusburghardt marcusburghardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@marcusburghardt marcusburghardt requested a review from Mab879 June 26, 2025 08:04
@Mab879 Mab879 merged commit ac66c26 into ComplianceAsCode:master Jun 30, 2025
131 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants