Remove unnecessary Jinja2 macros in control files

[marcusburghardt]

Description:

Remove unnecessary Jinja2 macros in control files so we can make the profiles more transparent, consistent and it also enable us to automatically process control files without bringing avoidable complexity to integrations.

It also ensure indentation consistence in profiles that were touched.

Rationale:

There is already a better mechanism to manage differences between selections in product agnostic control files and specific products using product profiles. This mechanism makes the profiles more transparent and removing Jinja2 macros from control files also allow us to use automation to process control files.

• docs: include ADR to define Jinja2 boundaries #13585

Review Hints:

CI tests should be enough to validate the changes.
Jinja2 macros were removed and the same outcome was achieved by updating the relevant product profiles when necessary.

The commits are organized by control files and produces, so it may be easier to review one by one.

UPDATE: The first 8 commits are part of the initial PR. The others are about fixing YAML lint issues.

A similar effort was already made in the past: #13180

[jan-cerny]

There is already a better mechanism to manage differences between selections in product agnostic control files and specific products using product profiles.

An alternative could be to introduce more structured schema for control YAML files, allowing us to define product-specific rules without having to involve Jinja2:

rules:
  - generic_rule_for_all
  - product=rhel9: rhel9_specific_rule
  - product_family=debian: debian_family_rule

[marcusburghardt]

There is already a better mechanism to manage differences between selections in product agnostic control files and specific products using product profiles.

An alternative could be to introduce more structured schema for control YAML files, allowing us to define product-specific rules without having to involve Jinja2:

rules:
  - generic_rule_for_all
  - product=rhel9: rhel9_specific_rule
  - product_family=debian: debian_family_rule

That is a nice idea @jan-cerny . I think that for now it is simpler to just remove the macros and manage the deltas in profiles. They are usually exceptions and not a big deal to edit few files. Actually, I personally like the simplicity of centralizing the profiles particularities in profile files. In any case, any mechanism that maintain the YAML syntax integer, so external scripts and integrations can process these files without needing to load and render Jinja2 macros would work.

[marcusburghardt]

Rebased and force-pushed to resolve the conflicts.

[marcusburghardt]

Included more commits to fix the YAML lint issues caught by CI Lint test. PR description updated in Review Hints section.

[qlty-cloud-legacy]

Code Climate has analyzed commit 965030c and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 61.9% (0.0% change).

View more on Code Climate.

[jan-cerny]

/test 4.12-images

[marcusburghardt]

FYI @teacup-on-rockingchair